KEMBAR78
improve Otel tracing by peterychang · Pull Request #6499 · microsoft/autogen · GitHub
Skip to content

improve Otel tracing #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2025
Merged

improve Otel tracing #6499

merged 6 commits into from
May 9, 2025

Conversation

@peterychang
Copy link
Contributor

Why are these changes needed?

Will the changes made in https://github.com/microsoft/autogen/pull/5853/files and this PR need to be ported to the worker_runtime as well?
Resolves #5894

Related issue number

#5894

Checks

@peterychang peterychang requested a review from ekzhu May 9, 2025 17:19
@jackgerrits
Copy link
Contributor

You can ignore worker runtime

@peterychang peterychang mentioned this pull request May 9, 2025
Closed
1 task
ekzhu
ekzhu previously requested changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@ekzhu ekzhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the GrpcAgentRuntime in the extension

Update: ignore

@ekzhu ekzhu dismissed their stale review May 9, 2025 19:06

ignore

@codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (356ec34) to head (067d80a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...src/autogen_core/_single_threaded_agent_runtime.py 88.88% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6499      +/-   ##
==========================================
+ Coverage   78.56%   78.57%   +0.01%     
==========================================
  Files         225      225              
  Lines       16549    16573      +24     
==========================================
+ Hits        13001    13023      +22     
- Misses       3548     3550       +2
Flag Coverage Δ
unittests 78.57% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterychang peterychang merged commit 3db7a29 into microsoft:main May 9, 2025
63 checks passed
peterj added a commit to peterj/autogen that referenced this pull request May 10, 2025
@peterj
Merge branch 'peterj/fix6481' of github.com:peterj/autogen into peter…
3863723 
…j/fix6481

* 'peterj/fix6481' of github.com:peterj/autogen:
  improve Otel tracing (microsoft#6499)
  Fix header icons focus and hover style for better accessibility (microsoft#6409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekzhu ekzhu ekzhu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improving OTEL tracing by adding more details about each message

3 participants

@peterychang @jackgerrits @ekzhu