-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Closed
Labels
ESMIssues caused by our AMD => ESM workIssues caused by our AMD => ESM workinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersmonaco-editor
Milestone
Description
Now that main runs with ESM, we had to disable some monaco related checks:
vscode/.github/workflows/monaco-editor.yml
Lines 68 to 98 in 6b924c5
| # - name: Editor Distro & ESM | |
| # run: yarn gulp editor-esm | |
| # - name: Editor ESM sources check | |
| # working-directory: ./test/monaco | |
| # run: yarn run esm-check | |
| # - name: Typings validation prep | |
| # run: | | |
| # mkdir typings-test | |
| # - name: Typings validation | |
| # working-directory: ./typings-test | |
| # run: | | |
| # yarn init -yp | |
| # ../node_modules/.bin/tsc --init | |
| # echo "import '../out-monaco-editor-core';" > a.ts | |
| # ../node_modules/.bin/tsc --noEmit | |
| # - name: Package Editor with Webpack | |
| # working-directory: ./test/monaco | |
| # run: yarn run bundle-webpack | |
| # - name: Compile Editor Tests | |
| # working-directory: ./test/monaco | |
| # run: yarn run compile | |
| # - name: Run Editor Tests | |
| # timeout-minutes: 5 | |
| # working-directory: ./test/monaco | |
| # run: yarn test |
//cc @alexdima
Metadata
Metadata
Labels
ESMIssues caused by our AMD => ESM workIssues caused by our AMD => ESM workinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersmonaco-editor