KEMBAR78
Provide emmet abbreviations via inline completions by hediet · Pull Request #147387 · microsoft/vscode · GitHub
Skip to content

Provide emmet abbreviations via inline completions #147387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2022
Merged

Provide emmet abbreviations via inline completions #147387

merged 2 commits into from
Apr 19, 2022

Conversation

@hediet
Copy link
Member

@hediet hediet commented Apr 13, 2022

This PR fixes #139247

@rzhao271 rzhao271 modified the milestones: April 2022, May 2022 Apr 13, 2022
@rzhao271 rzhao271 force-pushed the emmet-inline-completions branch from 2d2b300 to 23d2f84 Compare April 18, 2022 22:53
@rzhao271
Copy link
Collaborator

rzhao271 commented Apr 18, 2022 •
edited
Loading

I rebased the code and smoothed it out a bit so that

  • Depending on the setting, the inline or non-inline completion item provider is used.
  • One can switch the setting value and get the new completion item provider to be used right away. Though right now, it rebuilds all the language mappings and providers from scratch.

One issue I noticed is that with the inline completion item provider, if I press the enter key, I get a large error in the console:
A screenshot showing a long error stack trace

@hediet
Copy link
Member Author

hediet commented Apr 19, 2022

Thanks, looks great!

One issue I noticed is that with the inline completion item provider, if I press the enter key, I get a large error in the console:

This is a bug I need to investigate. But that bug is independent of this PR and shouldn't block you.

@rzhao271 rzhao271 marked this pull request as ready for review April 19, 2022 16:15
@rzhao271 rzhao271 merged commit 94de38e into main Apr 19, 2022
@rzhao271 rzhao271 deleted the emmet-inline-completions branch April 19, 2022 20:33
@rzhao271 rzhao271 modified the milestones: May 2022, April 2022 Apr 19, 2022
rzhao271 added a commit that referenced this pull request Apr 19, 2022
@rzhao271
Revert "Provide emmet abbreviations via inline completions (#147387)"
98db855 
This reverts commit 94de38e.
Reason: Found some bugs while demoing the feature.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@rzhao271 rzhao271

Labels

None yet

Projects

None yet

Milestone

April 2022

Development

Successfully merging this pull request may close these issues.

Can Emmet expand and wrap abbreviation commands use ghost text?

3 participants

@hediet @rzhao271