Adds an option to populate from snippet to a blank file prompt #173128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
previously approved these changes
Feb 2, 2023
src/vs/workbench/contrib/codeEditor/browser/untitledTextEditorHint/untitledTextEditorHint.ts
Outdated
Show resolved
Hide resolved
ulugbekna
force-pushed
the
pop-snippet-untitled
branch
from
04837fb to
20c7221
Compare
|
@ulugbekna thanks for driving this. "Select a language, or create from template, or open a different editor to get started." If you make more changes to this consider bringing it up in the UX call next week for feedback. |
jrieken
approved these changes
Feb 2, 2023
2 tasks
c-claeys
pushed a commit
to c-claeys/vscode
that referenced
this pull request
Feb 16, 2023
…soft#173128) * Adds an option to populate from snippet to a blank file prompt * Make the hint message a bit more readable * bring focus to editor when a snippet is applied to an empty file * rename "Apply file snippet" action --------- Co-authored-by: Ulugbek Abdullaev <uabdullaev@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I am a bit worried, however, that the new text is hard on eyes (difficult to read, "select language" and "create from template" are not well separated). Would something like this read better? Note how this prompt now indicates the "why" (to get started) first and has well separated buttons
other options:
cc @jrieken @isidorn