KEMBAR78
Remove bigNumbersDelta by remcohaszing · Pull Request #194712 · microsoft/vscode · GitHub
Skip to content

Conversation

@remcohaszing
Copy link
Contributor

If I understand correctly, this is just a hack to support IE. However, IE is no longer supported, so this is no longer necessary.

This is getting somewhat in the way of #194609.

@hediet
Copy link
Member

hediet commented Jan 4, 2024

Thanks!

@hediet hediet enabled auto-merge (squash) January 4, 2024 11:05
@vscodenpa vscodenpa added this to the December / January 2024 milestone Jan 4, 2024
If I understand correctly, this is just a hack to support IE. However,
IE is no longer supported, so this is no longer necessary.
@hediet hediet force-pushed the remove-bigNumbersDelta branch from 74a14f3 to 490e7ba Compare January 4, 2024 13:36
@remcohaszing
Copy link
Contributor Author

Correct me if I’m wrong, but the CI failure appears to be unrelated to these changes.

@hediet
Copy link
Member

hediet commented Jan 5, 2024

Yes, I believe so too

@hediet hediet merged commit fe249aa into microsoft:main Jan 5, 2024
@remcohaszing remcohaszing deleted the remove-bigNumbersDelta branch January 5, 2024 16:01
hediet added a commit that referenced this pull request Jan 15, 2024
hediet added a commit that referenced this pull request Jan 15, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants