chore: update to Electron 35 #245423
Merged
chore: update to Electron 35 #245423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://releases.electronjs.org/release/v35.1.4 out already. |
deepak1556
force-pushed
the
electron-35.x.y
branch
2 times, most recently
from
59ddd1d to
543e035
Compare
deepak1556
force-pushed
the
electron-35.x.y
branch
6 times, most recently
from
e865a77 to
f384038
Compare
|
Electron 35.2.0 out now: https://releases.electronjs.org/release/v35.2.0 |
deepak1556
force-pushed
the
electron-35.x.y
branch
3 times, most recently
from
2b69e4d to
3bb1edf
Compare
mkurz
reviewed
Apr 22, 2025
deepak1556
force-pushed
the
electron-35.x.y
branch
from
3bb1edf to
4c081bd
Compare
mkurz
reviewed
Apr 23, 2025
deepak1556
force-pushed
the
electron-35.x.y
branch
from
1a1cc88 to
51424aa
Compare
deepak1556
force-pushed
the
electron-35.x.y
branch
2 times, most recently
from
a4a1e7f to
ec6b550
Compare
|
Will this fix #53812? |
|
VSCode doesn't control the position of window controls, the runtime (Electron) draws it and there is currently no option to control the position. So this PR will not address #53812 |
Yeah, I know. I just had in my mind that either Electron 35 or 36 was the version that finally fixes that. But seems like this isn’t fixed in any of them: electron/electron#44540 Sorry for the noise |
deepak1556
force-pushed
the
electron-35.x.y
branch
from
b9b7b5a to
58746d0
Compare
bpasero
approved these changes
May 9, 2025
This was referenced May 9, 2025
Merged
meganrogge
added a commit
that referenced
this pull request
Jun 5, 2025
This reverts commit 12326f9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245420
Fixes #230303
Fixes #247054