ruff 0.8.0 fixes #24488
Merged
ruff 0.8.0 fixes #24488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visualstudio_py_testlauncher.py:133:24: UP031 Use format specifiers instead of percent format
karthiknadig
approved these changes
Nov 25, 2024
karthiknadig
added
the
debt
lszomoru
approved these changes
Nov 25, 2024
|
We typically keep python 3.8 support for 3 months after deprecation. Feb release is when we do official deprecation. Till then we would need to keep this from breaking. |
|
@joar I am reverting this change since 3.8 broke with this change. I will restore it, after we deprecate 3.8 support in the extension (which will be in Feb 2025). |
karthiknadig
added a commit
that referenced
this pull request
Nov 25, 2024
This reverts commit 98fea6e.
karthiknadig
added a commit
that referenced
this pull request
Nov 25, 2024
This reverts commit 98fea6e.
karthiknadig
added a commit
that referenced
this pull request
Nov 25, 2024
karthiknadig
pushed a commit
that referenced
this pull request
Nov 26, 2024
`ruff` 0.8.0 (released 2024-11-22) no longer defaults to supporting Python 3.8, > Ruff now defaults to Python 3.9 instead of 3.8 if no explicit Python version > is configured using [`ruff.target-version`](https://docs.astral.sh/ruff/settings/#target-version) > or [`project.requires-python`](https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#python-requires) > ([https://github.com/microsoft/vscode-python/pull/13896](https://github.com/astral-sh/ruff/pull/13896)) > — https://github.com/astral-sh/ruff/blob/f3dac27e9aa6ac6a20fc2fb27ff2e4f5d369b076/CHANGELOG.md#080 We want to support Python 3.8 until February 2025, so we need to set `target-version`. > The minimum Python version to target, e.g., when considering automatic code > upgrades, like rewriting type annotations. Ruff will not propose changes > using features that are not available in the given version. > — https://docs.astral.sh/ruff/settings/#target-version Can be used as an alternative to #24488 until py38 support is dropped. This PR also reverts the pinning of `ruff` merged in #24484.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff