bug: update quickCreateVenv to avoid name collisions for virtual environments #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
eleanorjboyd
commented
Jun 11, 2025
| path.join(venvRoot.fsPath, '.venv'), | ||
| { install: allPackages, uninstall: [] }, | ||
| ); | ||
| return quickCreateVenv(nativeFinder, api, log, manager, sortedEnvs[0], venvRoot, options.additionalPackages); |
There was a problem hiding this comment.
@karthiknadig just want to confirm this is good here to call the other command- seems intuitive to me but wasn't sure if there was a reason these were left separate
There was a problem hiding this comment.
As long as it is able to get the packages that it needs to install correctly.
There was a problem hiding this comment.
yep confirmed that works
rzhao271
approved these changes
Jun 12, 2025
sowhat1989
referenced
this pull request
in sowhat1989/vscode-python-environments
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #477