Switch windows-sys to use windows-link and thus raw-dylib
#3724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good news and I'm excited for the upcoming release! A friendly reminder that we should update the MSRV stated here ( |
Merged
will-j-wright
added a commit
to microsoft/openvmm
that referenced
this pull request
Sep 8, 2025
For a closed-source change, we need the newest version of the windows crates, specifically microsoft/windows-rs#3724 and microsoft/windows-rs#3743.
gurasinghMS
pushed a commit
to gurasinghMS/openvmm
that referenced
this pull request
Sep 9, 2025
For a closed-source change, we need the newest version of the windows crates, specifically microsoft/windows-rs#3724 and microsoft/windows-rs#3743.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows-sys crate is the last library crate provided by windows-rs to depend on the older windows-targets crate for linking rather than its modern replacement, the windows-link crate. Some of the biggest dependents of
windows-syshave since bumped their own MSRV to 1.70 so its probably time to think about movingwindows-sysforward.The
windows-linkcrate usesraw-dylibexclusively, providing simpler linking, faster and smaller download and compilation, and requiring no dependency on pre-built import libs.raw-dylibwas stabilized on Windows with Rust 1.71 so that becomes the new MSRV for the next version of thewindows-syscrate.Fixes: #3494