KEMBAR78
Component Governance fix: Update libyaml by yao-msft · Pull Request #4583 · microsoft/winget-cli · GitHub
Skip to content

Conversation

@yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Jun 26, 2024

Component governance fix: update libyaml

Since a new release has not been created since after 0.2.5, pull to latest master. I reviewed the commits and they look safe.

Microsoft Reviewers: Open in CodeFlow

yao-msft added 3 commits June 25, 2024 22:16
840b65c4 Fix closing flow sequence after explicit key
588eabff Handle closing flow sequence after explicit key
abd744ec ci: Install libtool on macOS
1e66c1e1 Fix some typos
51843fe4 Limit depth of nesting by default
fb57d89c Update Github actions
f8f760f7 ci: Fix build on macOS (microsoft#230)
acd6f6f0 Add workflow for creating release tarballs

git-subtree-dir: src/YamlCppLib/libyaml
git-subtree-split: 840b65c40675e2d06bf40405ad3f12dec7f35923
@yao-msft yao-msft requested a review from a team as a code owner June 26, 2024 05:25
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to not squash the merge.

@yao-msft yao-msft merged commit 015f0e9 into microsoft:master Jun 26, 2024
@yao-msft yao-msft deleted the libyamlupdate branch June 26, 2024 17:23
ryfu-msft pushed a commit to ryfu-msft/winget-cli that referenced this pull request Jun 26, 2024
Component governance fix: update libyaml
ryfu-msft added a commit that referenced this pull request Jun 26, 2024
florelis added a commit that referenced this pull request May 13, 2025
We have a Component Governance alert for libyaml. There is no release of
libyaml with this issue fixed, so the guidance was to apply the patch
manually, and that's what I did when moving to vcpkg, but that doesn't
play nicely with CG because it can't determine that the patch to fix the
vulnerability was applied.

Instead of manually patching, this PR uses a more recent commit of
libyaml (without an official release), which already has the changes we
want. It uses the same commit from the last time we did a subtree update
in #4583

---------

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants