Don't let unset error codes be thrown #5255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Feb 27, 2025
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Feb 27, 2025
## Change Some of the `http_exception`s coming through this function don't have error codes set. Throwing that success code causes WIL to fail fast.
JohnMcPMS
added a commit
that referenced
this pull request
Feb 27, 2025
## Change Some of the `http_exception`s coming through this function don't have error codes set. Throwing that success code causes WIL to fail fast. CP from #5255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Some of the
http_exceptions coming through this function don't have error codes set. Throwing that success code causes WIL to fail fast.Validation
Forced an exception without a code to be thrown (force the Store DNS to map to another web server so that the certificate did not match).
Microsoft Reviewers: Open in CodeFlow