Only download during COM download #5327
Merged
+52
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Issue-Bug
yao-msft
previously approved these changes
Mar 26, 2025
yao-msft
approved these changes
Mar 27, 2025
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Apr 1, 2025
Fixes microsoft#4661 ## Issue When `download` was added, the COM download and install split for dependencies was accidentally implemented. But it was validated only with download in mind, so the download part worked for download intent. With dependencies, the split basically attempted to install the dependencies twice, causing a failure on the second attempt due to internal assertions. ## Change For the COM download command, explicitly force that we are only downloading.
JohnMcPMS
added a commit
that referenced
this pull request
Apr 1, 2025
Cherry pick #5327 to 1.10 ## Issue When `download` was added, the COM download and install split for dependencies was accidentally implemented. But it was validated only with download in mind, so the download part worked for download intent. With dependencies, the split basically attempted to install the dependencies twice, causing a failure on the second attempt due to internal assertions. ## Change For the COM download command, explicitly force that we are only downloading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4661
Issue
When
downloadwas added, the COM download and install split for dependencies was accidentally implemented. But it was validated only with download in mind, so the download part worked for download intent. With dependencies, the split basically attempted to install the dependencies twice, causing a failure on the second attempt due to internal assertions.Change
For the COM download command, explicitly force that we are only downloading.
Validation
Added a test that reproduces the double install attempt and verified that it failed at the attempt to move backward in execution phase. Test succeeds after the change.
Microsoft Reviewers: Open in CodeFlow