Remove most checked-in dependency libraries #5390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
Apr 16, 2025
florelis
added a commit
that referenced
this pull request
Apr 22, 2025
Follow-up to #5390 We have copies of `PureLib` and `UndockedRegFreeWinRT` in the repo that themselves include code from their dependencies (`catch2`, `zlib`). This PR removes that code in favor of using vcpkg to fetch the dependencies. For `PureLib`, after removing `zlib`, there are only headers left. So I replaced the `.vcxproj` with a `.vcxitems` For `UndockedRegFreeWinRT`, I removed all the test code along with the copy of catch2. Updated the READMEs for the subtrees, although I'm not certain a subtree update would still work... ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the code for most of the dependency libraries that was checked in, in favor of getting them from vcpkg. This required enabling vcpkg for some projects, like Fuzzing.
The dependencies removed are:
catch2JsonCppLibValijsonyamlcppdetours(transitive dependency ofUndockedRegFreeWinRT)From
PureLib, also removed the transitive dependencydotzlib. We don't need a replacement for this one.Moving
catch2to vcpkg also brought in a major update (v2->v3), which required some changes in the included headers and namespaces.From
cpprestsdk, removed some of the code we don't need, like samples and build pipelines. We should remove all ofcpprestsdk, but it is not as straightforward because we modified it for certificate pinning, so we need to apply a patch on top of the original code from the port.PureLibandsfs-clientweren't removed because there is no equivalent in vcpkg.Microsoft Reviewers: Open in CodeFlow