-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added dscv3 user-settings resource #5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
else | ||
{ | ||
AICLI_LOG(Config, Error, << "Failed to open user settings file: " << _userSettingsPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having a settings file is a legitimate state (in fact, the most likely state on a new system).
Add a test(s) that ensures proper handling when the settings file does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today a settings file is required in order to use this feature (experimentalFeature > dsc3 = true).
For instance, if we don't have a settings.json
file and we do:
'{}' | winget dscv3 user-settings-file --set
or
winget dscv3 user-settings-file --get
We get:
This feature is a work in progress, and may be changed dramatically or removed altogether in the future. To enable it, edit your settings ('winget settings') to include the experimental feature: 'dsc3'
I will consider a way to handle this logic with test hooks but I will handle that part in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user-settings
resource based on the v2 implementationMicrosoft Reviewers: Open in CodeFlow