KEMBAR78
Added dscv3 user-settings resource by AmelBawa-msft · Pull Request #5421 · microsoft/winget-cli · GitHub
Skip to content

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented May 1, 2025

  • Added support for dscv3 user-settings resource based on the v2 implementation
  • Added unit test
Microsoft Reviewers: Open in CodeFlow

@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner May 1, 2025 06:44
}
else
{
AICLI_LOG(Config, Error, << "Failed to open user settings file: " << _userSettingsPath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having a settings file is a legitimate state (in fact, the most likely state on a new system).

Add a test(s) that ensures proper handling when the settings file does not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today a settings file is required in order to use this feature (experimentalFeature > dsc3 = true).

For instance, if we don't have a settings.json file and we do:

'{}' | winget dscv3 user-settings-file --set

or

winget dscv3 user-settings-file --get

We get:

This feature is a work in progress, and may be changed dramatically or removed altogether in the future. To enable it, edit your settings ('winget settings') to include the experimental feature: 'dsc3'

I will consider a way to handle this logic with test hooks but I will handle that part in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmelBawa-msft AmelBawa-msft merged commit 6e092a6 into master May 2, 2025
11 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/user-settings-dscv3 branch May 2, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants