Shared build props #5749
Merged
Shared build props #5749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Sep 26, 2025
JohnMcPMS
added a commit
that referenced
this pull request
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Due to an issue with the internal build, it was realized that we could be violating ODR due to a mismatch on the build configurations. This change moves to using the MSBuild
Directory.Build.propsfile to have all projects use the same settings. It also adds a header using#pragma detect_mismatchto attempt to detect the issue at compilation. This header is then included by the errors header, which is used by at least one TU in every project, if not all of them.Microsoft Reviewers: Open in CodeFlow