KEMBAR78
Add admin check to uninstall of machine font by dkbennett · Pull Request #5779 · microsoft/winget-cli · GitHub
Skip to content

Conversation

dkbennett
Copy link
Member

@dkbennett dkbennett commented Oct 7, 2025

Fixes #5774

Adds an admin check to the font uninstall flow.

Non-elevated uninstall of machine font
image

Elevated uninstall of machine font
image

Tested:

  • Uninstall of machine installed font succeeds from elevated command prompt.
  • Uninstall of machine font from non-elevated command prompt fails.

No release note update required for this, fixes a bug in unreleased code.


Microsoft Reviewers: Open in CodeFlow

@mdanish-kh
Copy link
Contributor

Uninstall of machine font from non-elevated command prompt fails.

Is a prompt for elevation flow part of future plans, or blocked by some issue?

@denelon
Copy link
Collaborator

denelon commented Oct 7, 2025

Future plans

Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that using the EnsureRunningAsAdmin task would probably make any future update to auto-elevate easier (assuming that the auto-elevate was implemented universally using some form of "run with same args elevated" flow).

@dkbennett dkbennett merged commit 53e6c0c into microsoft:master Oct 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font Uninstall from non-elevated command on a machine-scope font succeeds but does nothing

4 participants