Improve window thread termination #5781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
reviewed
Oct 9, 2025
| BOOL getMessageResult; | ||
| while ((getMessageResult = GetMessage(&msg, m_windowHandle.get(), 0, 0)) != 0) | ||
| // Message loop, exits when the window handle has been destroyed | ||
| while (m_windowThreadShouldRun.load()) |
There was a problem hiding this comment.
nit: do we need the load()
…tMessage to block instead of polling
yao-msft
reviewed
Oct 9, 2025
| #include <AppInstallerRuntime.h> | ||
| #include <winget/COMStaticStorage.h> | ||
|
|
||
| using namespace std::chrono_literals; |
JohnMcPMS
added a commit
that referenced
this pull request
Oct 10, 2025
Ports #5781 to the 1.11 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Shut down the window thread as part of the
TerminationSignalHandlerdestruction.Properly unregister the window class after destroying the window on the thread.
Signal the shutdown via an
atomic_bool.Microsoft Reviewers: Open in CodeFlow