Fix cgroup-network spawn server cleanup on fatal exit #21080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When cgroup-network calls
fatal()after creating its spawn server (line 759), the spawn server process is orphaned and reparented to PID 1. When in Docker netdata runs as PID 1 (not by default), and when the orphaned spawn server exits, it becomes a zombie because netdata is not reaping non-child processes.Solution
Register a fatal callback that properly destroys the spawn server before exit:
cleanup_spawn_server_on_fatal()callbackspawn_server = NULLafter destruction in both cleanup paths (fatal callback + normal exit)Safety Analysis
Test Plan
NETDATA_HOST_PREFIXto trigger fatal()Fixes #20565