Fix duplicate header leak in ACLK HTTPS client #21084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsaou
commented
Oct 1, 2025
| } | ||
| void *prev_val = NULL; | ||
| if (!c_rhash_get_ptr_by_str(parse_ctx->headers, key, &prev_val)) | ||
| freez(prev_val); // drop previous allocation before overwriting |
There was a problem hiding this comment.
@stelfrag if you don't want to keep the rest, the above 2 lines fix the actual leak.
All the others are supposed to make this more robust.
stelfrag
approved these changes
Oct 2, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Oct 3, 2025
fix(aclk): free previous header values before overwrite Refs: netdata#21083 (cherry picked from commit 41d9554)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21083
In other works, aclk was leaking the value of each duplicate http response header key received. It was using the last, but all previous were leaked. Now it frees duplicates before allocating a new one (still uses the last one).