KEMBAR78
Fix app.mem_usage (Windows) by thiagoftsm · Pull Request #21085 · netdata/netdata · GitHub
Skip to content

Conversation

@thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Oct 2, 2025

Summary

The app.mem_usage value on Windows currently has a major discrepancy with the Windows Task Manager due to an incorrect data collection key.

This PR fixes the issue by correcting the variable name, bringing the reported value much closer to Task Manager's.

This branch:
pr

Next image shows this PR on left and current master on right:

pr
Test Plan
  1. Build current master, generate installer and install it.
  2. Go to app.mem_usage select netdata and compare with Task Manager values.
  3. Now, compile this branch, and install it.
  4. Repeat step 2.
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/apps labels Oct 2, 2025
@thiagoftsm thiagoftsm requested review from ilyam8 and stelfrag October 2, 2025 02:05
@thiagoftsm thiagoftsm changed the title Fix mem_usage in apps.plugin (Windows version) Fix app.mem_usage (Windows) Oct 2, 2025
Copy link
Member

@ilyam8 ilyam8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mem_private_usage can be removed on Win after this change

@thiagoftsm
Copy link
Contributor Author

Hello @ilyam8 ,

I've just checked the mem_private_usage metric on Windows using the master branch, and it is also not providing the expected result:

pr

This is likely because the mem_usage value it relies on is also incorrect.

@thiagoftsm thiagoftsm merged commit 55f71b4 into netdata:master Oct 2, 2025
108 checks passed
@thiagoftsm thiagoftsm deleted the fix_apps branch October 2, 2025 17:43
@ilyam8
Copy link
Member

ilyam8 commented Oct 2, 2025

Hello @ilyam8 ,

I've just checked the mem_private_usage metric on Windows using the master branch, and it is also not providing the expected result:

pr This is likely because the `mem_usage` value it relies on is also incorrect.

No, it is not. You didn’t understand my message.

stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Oct 3, 2025
@stelfrag stelfrag mentioned this pull request Oct 3, 2025
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Oct 3, 2025
Ferroin pushed a commit that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection collectors/apps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants