KEMBAR78
Address NULL access (windows.plugin) by thiagoftsm · Pull Request #21112 · netdata/netdata · GitHub
Skip to content

Conversation

@thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Oct 7, 2025

Summary

During testing on Windows Server 2016, we discovered issues in the storage thread. The event's stack trace is unclear, showing only a reference to a NULL pointer.

fatal":{ "line":0, "filename":"", "function":"thread:P[windows]:8", "message":"", "errno":"", "thread":"P[windows]", "thread_id":31528, "stack_trace":"info: will now attempt to get stack trace - if you see this message, we couldn't get it.", "signal_code":"SIGABRT/SI_USER", "sentry":false, "fault_address":"0x0", "worker_job_id":8 } } 

To resolve this, the PR removes all NULL pointers passed as arguments.

This event does not happen in newer Windows Versions.

Test Plan
  1. Compile this branch and install it on Windows.
  2. Observe storage charts on dashboard.
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/windows labels Oct 7, 2025
@thiagoftsm thiagoftsm marked this pull request as ready for review October 7, 2025 23:58
@thiagoftsm thiagoftsm requested a review from stelfrag October 7, 2025 23:59
@stelfrag stelfrag merged commit 3d60322 into netdata:master Oct 8, 2025
109 of 110 checks passed
@thiagoftsm thiagoftsm deleted the address_null branch October 8, 2025 11:21
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Oct 15, 2025
address_null: Change NULL to valid address trying to avoid reported issue

(cherry picked from commit 3d60322)
@stelfrag stelfrag mentioned this pull request Oct 15, 2025
Ferroin pushed a commit that referenced this pull request Oct 15, 2025
address_null: Change NULL to valid address trying to avoid reported issue

(cherry picked from commit 3d60322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection collectors/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants