-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Improve agent startup on windows #21125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows service is starting normally with this PR. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stelfrag after few minutes running this branch stopped running.
7f32698 to
350315a
Compare
|
Following the latest commits, the system ran successfully for three consecutive hours. |
350315a to
73cee74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is working as expected on Linux and Windows. LGTM!
* Exclude Windows from temporary spawn server initialization and cleanup * Additional checks to isolate windows deadlock issue * Switch to sleep_usec * Cast revents to unsigned int for log clarity in log forwarder (cherry picked from commit 3e65147)
* Exclude Windows from temporary spawn server initialization and cleanup * Additional checks to isolate windows deadlock issue * Switch to sleep_usec * Cast revents to unsigned int for log clarity in log forwarder (cherry picked from commit 3e65147)
Summary