Add conditional on listing inference pools for status #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4104 +/- ##
==========================================
- Coverage 86.62% 86.50% -0.13%
==========================================
Files 131 131
Lines 17794 17796 +2
Branches 74 74
==========================================
- Hits 15414 15394 -20
- Misses 2182 2200 +18
- Partials 198 202 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
approved these changes
Oct 17, 2025
ciarams87
approved these changes
Oct 20, 2025
shaun-nx
approved these changes
Oct 20, 2025
bjee19
added a commit
that referenced
this pull request
Oct 20, 2025
Add a conditional to inference pool status, so we make a k8sclient call on the InferencePool object only if inference extension is enabled.
bjee19
added a commit
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a conditional to inference pool status, so we make a k8sclient call on the InferencePool object only if inference extension is enabled.
Without this fix, if you deploy NGF on main without the inference extension flag enabled, it will print out this error message:
{"level":"error","ts":"2025-10-17T22:34:47Z","logger":"eventHandler","msg":"error listing InferencePools for status update","error":"no matches for kind \"InferencePool\" in version \"inference.networking.k8s.io/v1\"","stacktrace":"github.com/nginx/nginx-gateway-fabric/v2/internal/controller.(*eventHandlerImpl).updateStatuses\n\tgithub.com/nginx/nginx-gateway-fabric/v2/internal/controller/handler.go:378\ngithub.com/nginx/nginx-gateway-fabric/v2/internal/controller.(*eventHandlerImpl).waitForStatusUpdates\n\tgithub.com/nginx/nginx-gateway-fabric/v2/internal/controller/handler.go:295"}However, there should be no functionality impact by this error message.