KEMBAR78
Fix helm tests in release pipeline by ciarams87 · Pull Request #4126 · nginx/nginx-gateway-fabric · GitHub
Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: Helm local tests are failing in the release branch

Solution: Add the correct docker tags meta for release branch, and add tag input for production release. Also fixed a bug where we would have a double v in the tag name for build images checkout on the production release

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner October 21, 2025 21:34
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (9fbef71) to head (c9ce65f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4126      +/-   ##
==========================================
- Coverage   86.53%   86.46%   -0.07%     
==========================================
  Files         131      131              
  Lines       17796    17796              
  Branches       74       74              
==========================================
- Hits        15399    15387      -12     
- Misses       2197     2207      +10     
- Partials      200      202       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this also need to be merged into the release branch?

@ciarams87 ciarams87 merged commit 06c40f2 into main Oct 22, 2025
60 of 61 checks passed
@ciarams87 ciarams87 deleted the chore/fix-helm-release branch October 22, 2025 07:11
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 22, 2025
ciarams87 added a commit that referenced this pull request Oct 22, 2025
ciarams87 added a commit that referenced this pull request Oct 22, 2025
* Fix helm tests in release pipeline (#4126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants