KEMBAR78
Set parents after insert call by nlohmann · Pull Request #4537 · nlohmann/json · GitHub
Skip to content

Conversation

nlohmann
Copy link
Owner

Closes #3915

@nlohmann nlohmann self-assigned this Dec 12, 2024
@nlohmann nlohmann mentioned this pull request Dec 12, 2024
2 tasks
@coveralls
Copy link

Coverage Status

coverage: 99.65%. remained the same
when pulling cb41608 on issue3915
into e6cafa5 on develop.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Dec 16, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 18, 2024
@nlohmann nlohmann merged commit 094bd26 into develop Dec 18, 2024
122 checks passed
@nlohmann nlohmann deleted the issue3915 branch December 18, 2024 08:44
nlohmann added a commit that referenced this pull request Dec 18, 2024
* 🐛 set parents after insert call

* 🚨 fix warning
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* 🐛 set parents after insert call

* 🚨 fix warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M review needed It would be great if someone could review the proposed changes. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON_DIAGNOSTICS trigger assertion

2 participants