KEMBAR78
Fix `pending_version` not set after module update by GogoVega · Pull Request #5169 · node-red/node-red · GitHub
Skip to content

Conversation

GogoVega
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

In #4945, I modified the nodeEntries[module].info object to separate the set into nodeSet and pluginSet.

With this change nodeEntries[module].info no longer contains a reference to the registry (RED.nodes.registry.getModule(module)) but to a new object.

So have to define pending_version during the update event to add it to nodeEntries[module].info.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 407d231 into node-red:dev Jun 11, 2025
4 checks passed
@GogoVega GogoVega deleted the fix-pending-version branch June 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants