Fix pending_version
not set after module update
#5169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Proposed changes
In #4945, I modified the
nodeEntries[module].info
object to separate the set intonodeSet
andpluginSet
.With this change
nodeEntries[module].info
no longer contains a reference to the registry (RED.nodes.registry.getModule(module)
) but to a new object.So have to define
pending_version
during the update event to add it tonodeEntries[module].info
.Checklist
npm run test
to verify the unit tests pass