KEMBAR78
test_runner: abort unfinished tests on async error by cjihrig · Pull Request #51996 · nodejs/node · GitHub
Skip to content

test_runner: abort unfinished tests on async error #51996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2024
Merged

test_runner: abort unfinished tests on async error #51996

merged 1 commit into from
Mar 9, 2024

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 7, 2024

This commit updates the test runner's uncaughtException handler to abort tests instead of assuming they finished running.

Fixes: #51381

@cjihrig
test_runner: abort unfinished tests on async error
db7b145 
This commit updates the test runner's uncaughtException handler
to abort tests instead of assuming they finished running.

Fixes: nodejs#51381
@cjihrig cjihrig requested a review from MoLow March 7, 2024 01:12
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 7, 2024
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57605/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57608/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57634/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit 29b2317 into nodejs:main Mar 9, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 29b2317

@cjihrig cjihrig deleted the issue51381 branch March 9, 2024 23:28
@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Mar 18, 2024
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 18, 2024 •
edited
Loading

This is being reverted due to #52139

EDIT: This was not reverted (#52146). Removing the don't land labels.

@cjihrig cjihrig removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Mar 19, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@cjihrig @rdw-msft
test_runner: abort unfinished tests on async error
7dbb3da 
This commit updates the test runner's uncaughtException handler
to abort tests instead of assuming they finished running.

Fixes: nodejs#51381
PR-URL: nodejs#51996
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@cjihrig @marco-ippolito
test_runner: abort unfinished tests on async error
a4cbb61 
This commit updates the test runner's uncaughtException handler
to abort tests instead of assuming they finished running.

Fixes: #51381
PR-URL: #51996
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
@cjihrig @jcbhmr
test_runner: abort unfinished tests on async error
da8ad7e 
This commit updates the test runner's uncaughtException handler
to abort tests instead of assuming they finished running.

Fixes: nodejs#51381
PR-URL: nodejs#51996
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner: spurious "Promise resolution is still pending but the event loop has already resolved" when a callback tests fails

6 participants

@cjihrig @nodejs-github-bot @benjamingr @MoLow @atlowChemi @aduh95