test: add spawnSyncAndAssert util
#52132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
reviewed
Mar 18, 2024
aduh95
force-pushed
the
spawnSyncAndExitWithoutError
branch
from
dbd8884 to
a83410d
Compare
aduh95
changed the title
spawnSyncAndExitWithoutErrorspawnSyncAndExitWithoutErrorAndAssert util
legendecas
approved these changes
Mar 20, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
|
The length of the name seems to get out of hands a bit...can this just be |
MoLow
approved these changes
Mar 20, 2024
aduh95
force-pushed
the
spawnSyncAndExitWithoutError
branch
from
a83410d to
74abb83
Compare
aduh95
changed the title
spawnSyncAndExitWithoutErrorAndAssert utilspawnSyncAndAssert util
aduh95
force-pushed
the
spawnSyncAndExitWithoutError
branch
from
74abb83 to
9dfd601
Compare
aduh95
commented
Mar 20, 2024
github-actions
bot
removed
the
request-ci
|
Landed in c714cda |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52132 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52132 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52132 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spawnSyncAndExitWithoutErrorwill use the last argument as a bag of expectations, but will also pass it tospawnSync. That sometimes causes problems if the expectations are incompatible with the bag of optionsspawnSyncexpects. With this PR, all arguments but the last one is passed tospawnSync, making for a more comprehensible API.