doc: update the location of build_with_cmake
#52356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
tniessen
approved these changes
Apr 4, 2024
UlisesGascon
approved these changes
Apr 4, 2024
gengjiawen
approved these changes
Apr 4, 2024
NickNaso
approved these changes
Apr 5, 2024
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2c77be5 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52356 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52356 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
The
nodejs/node-addon-examplesPR#341 moved the location ofbuild_with_cmaketosrc/8-tooling/build_with_cmake. This PR adjusts the docs to changes.