doc: update test runner coverage limitations #52515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
MoLow
force-pushed
the
test-runner-update-coverage-limitations
branch
from
6d0bf7b to
f73e249
Compare
atlowChemi
approved these changes
Apr 13, 2024
benjamingr
approved these changes
Apr 14, 2024
TKDev7
reviewed
Apr 14, 2024
cjihrig
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
LGTM, but I kind of agree with @atlowChemi. Either way works for me though.
MoLow
force-pushed
the
test-runner-update-coverage-limitations
branch
from
f73e249 to
7b0a45d
Compare
atlowChemi
approved these changes
Apr 15, 2024
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7453480 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52515 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52515 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52515 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #52060 (comment)