KEMBAR78
docs: migrate existing docs to gatsby by claudiahdz · Pull Request #274 · npm/cli · GitHub
Skip to content

Conversation

@claudiahdz
Copy link
Contributor

@claudiahdz claudiahdz commented Oct 31, 2019

This PR migrates our old CLI docs website to a new Gatsby generated one.

Changes:

  • Deleted both html and doc folders
  • Modified Makefile with new docs build process
  • Refactored to node doc-build.sh
  • Added new Gatsby website
  • Modified lib/help.js to handle the new path where docs live
  • Updated tests with proper docs path

@claudiahdz claudiahdz requested a review from a team as a code owner October 31, 2019 16:59
oletizi and others added 2 commits October 31, 2019 19:36
- Added an install page (copied from existing online docs)
- Added a FeatureLink component to components/links.js

note: external link on features page has a hack for styling; that should probably be fixed, but want to get the copy to the team asap.
@claudiahdz claudiahdz force-pushed the docs/new-gatsby-site branch from a14115a to 4515e7c Compare November 4, 2019 19:12
@claudiahdz claudiahdz force-pushed the docs/new-gatsby-site branch from e0068a1 to 1d7a2ae Compare November 5, 2019 16:06
richardlau added a commit to richardlau/cli that referenced this pull request Dec 2, 2019
A few references to the `doc` target were not updated to `docs` in
npm#274 and resulted in `make release`
not building the docs.
mikemimik pushed a commit that referenced this pull request Dec 3, 2019
A few references to the `doc` target were not updated to `docs` in
#274 and resulted in `make release`
not building the docs.

PR-URL: #546
Credit: @richardlau
Close: #546
Reviewed-by: @mikemimik
@claudiahdz claudiahdz deleted the docs/new-gatsby-site branch December 11, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants