KEMBAR78
Enhance chrome.app.window API with window background color by fujunwei · Pull Request #82 · nwjs/chromium.src · GitHub
Skip to content

Conversation

@fujunwei
Copy link
Contributor

The default background color of window is white, a flash of white
will be shown if the loaded page uses a dark background. So add a new
property named background_color to CreateWindowOptions that can be configured
the same as page dark background instead of white default color.

gogerald and others added 30 commits February 22, 2017 14:25
…utofill

July is formatted to 07 instead of 7

BUG=693635

Review-Url: https://codereview.chromium.org/2708183002
Cr-Commit-Position: refs/heads/master@{#451863}
(cherry picked from commit 3d0ee98)

Review-Url: https://codereview.chromium.org/2709103003 .
Cr-Commit-Position: refs/branch-heads/2987@{#641}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Offline Previews metrics will not be reported currently because the
MIME-type sniffing only allows text/html or application/xhtml+xml.
MHTML, entires pages saved as one file are mime-type multipart/related
(https://en.wikipedia.org/wiki/MIME#Multipart_subtypes). Offline
previews are treated as HTTP/HTTPS MHTML pages from the perspective of
the chrome page load metrics harness, and treated as HTML documents in
blink. This should mean that offline pages are the only class of MHTML
pages that will be tracked in the harness.

BUG=693776

Review-Url: https://codereview.chromium.org/2699213002
Cr-Commit-Position: refs/heads/master@{#451906}
(cherry picked from commit 07205c9)

Review-Url: https://codereview.chromium.org/2708213005 .
Cr-Commit-Position: refs/branch-heads/2987@{#642}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
…focus advancing (https://codereview.chromium.org/2295843006)

Revert reason:
Revert to get rid of the crash before having a proper fix.

TBR=xiyuan@chromium.org, stevenjb@chromium.org, achuith@chromium.org
BUG=692784
BUG=468969
TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen.

Review-Url: https://codereview.chromium.org/2709593002
Cr-Commit-Position: refs/heads/master@{#451983}
(cherry picked from commit 26f0153)

Review-Url: https://codereview.chromium.org/2711793002 .
Cr-Commit-Position: refs/branch-heads/2987@{#643}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693292
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2692203009
Cr-Commit-Position: refs/heads/master@{#451794}
(cherry picked from commit 31b2815)

Review-Url: https://codereview.chromium.org/2710073002
Cr-Commit-Position: refs/branch-heads/2987@{#644}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Fixed an issue where persistent pages would be deleted by storage manager
when clearing expired pages.

BUG=691023

Review-Url: https://codereview.chromium.org/2700563005
Cr-Commit-Position: refs/heads/master@{#451405}
(cherry picked from commit 0386b22)

Review-Url: https://codereview.chromium.org/2707363002 .
Cr-Commit-Position: refs/branch-heads/2987@{#645}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
…ong place

The previous code I introduced in DocumentMarkerController::setComposition()
was passing an offset measured in DOM children to addCompositionUnderlines()
(and it wasn't even measured correctly) when it should have been passing an
offset measured in plain text characters. Oops

I'd like to add a test case for this bug, unfortunately I'm having trouble
reproducing it in a test.

BUG=692699

Review-Url: https://codereview.chromium.org/2689233006
Cr-Commit-Position: refs/heads/master@{#451903}
(cherry picked from commit 6923513)

Review-Url: https://codereview.chromium.org/2709343002 .
Cr-Commit-Position: refs/branch-heads/2987@{#646}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
To discourage development patterns leading to bad user experience, we
block wasm compilation/instantiation through the sync APIs
for modules larger than a certain size.

Promise-based APIs still succeed; also, sync APIs succeed in worker
contexts.

BUG=693945

R=bradnelson@chromium.org,esprehn@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2702953002
Cr-Commit-Position: refs/heads/master@{#451811}
(cherry picked from commit 50e18a2)

Review-Url: https://codereview.chromium.org/2713733002 .
Cr-Commit-Position: refs/branch-heads/2987@{#647}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
This is in preparation of v8 supporting that version only. It currently
supports both 0x1 and 0xD.

BUG=chromium:575167
BUG=chromium:694657

Review-Url: https://codereview.chromium.org/2710033002
Cr-Commit-Position: refs/heads/master@{#452165}
(cherry picked from commit 85df088)

Review-Url: https://codereview.chromium.org/2707263007 .
Cr-Commit-Position: refs/branch-heads/2987@{#648}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648593002
Cr-Commit-Position: refs/heads/master@{#445392}
(cherry picked from commit 37e33d5)

Review-Url: https://codereview.chromium.org/2707053006 .
Cr-Commit-Position: refs/branch-heads/2987@{#649}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Remove GMS from upstream WebView (it's only needed downstream) and
create a google_play_services_package variable with the upstream GMS
location, so it can be overridden downstream.

BUG=662166

Review-Url: https://codereview.chromium.org/2697543004
Cr-Commit-Position: refs/heads/master@{#450780}
(cherry picked from commit 635a452)

Review-Url: https://codereview.chromium.org/2712863002 .
Cr-Commit-Position: refs/branch-heads/2987@{#650}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
We've seen enough breakages to justify reverting for now.
We'll try again in a later release.

BUG=624061

Review-Url: https://codereview.chromium.org/2693423008
Cr-Commit-Position: refs/heads/master@{#451933}
(cherry picked from commit 1cb8abd)

Review-Url: https://codereview.chromium.org/2710953005 .
Cr-Commit-Position: refs/branch-heads/2987@{#651}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
For the chrome os recovery tool, it used to use "/var/tmp" to store
the downloaded image and intermediate unzipped files. The folder is
on a disk partition with a max size of ~3GB. Since arc++, the image
size grows bigger over the size limitation. We decide to use the
current user's Download folder instead.

Cherry pick change list 2662103005 into M57.

BUG=687422
TEST=manually tested on a chromebox.
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2662103005
Cr-Commit-Position: refs/heads/master@{#449198}
(cherry picked from commit 1275040)

Review-Url: https://codereview.chromium.org/2711473009
Cr-Commit-Position: refs/branch-heads/2987@{#652}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#653}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
If text insertion causes focus to be lost, then FocusController calls
InputMethodController::willChangeFocus(), and eventually calls
finishComposingText(DoNotKeepSelection).

But DoNotKeepSelection actually moves the caret to the end of the current
composition, so the caret will end up at the start of the inserted text.
Simply switching to KeepSelection fixes this issue.

BUG=691666

Review-Url: https://codereview.chromium.org/2705183002
Cr-Commit-Position: refs/heads/master@{#452002}
(cherry picked from commit c203f3a)

Review-Url: https://codereview.chromium.org/2706403005 .
Cr-Commit-Position: refs/branch-heads/2987@{#654}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Clears out the external protocol data stored on Profile, when user
clears browsing history, and checks 'cookies and other site and plugin
data'.

BUG=457254
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2664253006
Cr-Commit-Position: refs/heads/master@{#451517}
(cherry picked from commit 561a9cd)

Review-Url: https://codereview.chromium.org/2710603007
Cr-Commit-Position: refs/branch-heads/2987@{#655}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
This updates from revision
48ff55eab9b82ebc88762eed45277448d1f4f79 (2016-11-29)

to revision
1b9ceb762bda9cba75066b8be3c73aed634fd82f (2017-02-23)

TBR=pkasting@chromium.org
BUG=686800

Review-Url: https://codereview.chromium.org/2712883002
Cr-Commit-Position: refs/heads/master@{#452364}
(cherry picked from commit 5c1bebe)

Review-Url: https://codereview.chromium.org/2713823002 .
Cr-Commit-Position: refs/branch-heads/2987@{#656}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
This bug occurs because during an animation we may change the amount of layout
overflow (via FrameView::recalcOverflowAfterStyleChange). Previously, this
would cause a change in scrollbar existance until r432965 made it so that the
FrameView would prevent scrollbar creation earlier in cases where they're known
to be unneeded. Changing scrollbar existence causes a layout so we'd implicitly
invalidate and repaint. Since that change, we (correctly) don't bother doing a
layout but because of that we no longer invalidate so the additionally exposed
background region doesn't get painted.

BUG=683814

Review-Url: https://codereview.chromium.org/2685883004
Cr-Commit-Position: refs/heads/master@{#452170}
(cherry picked from commit 717789e)

Review-Url: https://codereview.chromium.org/2711033004 .
Cr-Commit-Position: refs/branch-heads/2987@{#657}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
BUG=682067

Review-Url: https://codereview.chromium.org/2690613003
Cr-Commit-Position: refs/heads/master@{#449998}
(cherry picked from commit 34bda99)

Review-Url: https://codereview.chromium.org/2716603002 .
Cr-Commit-Position: refs/branch-heads/2987@{#658}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
This patch fixes to choose the correct hyphenation point when the word
has multiple hyphenation points on Android.

The line breaker computes the number of characters that can fit and
computes that last hyphenation point within the number. The number was
not used correctly in the Android hyphenation engine.

The fix is about 5 lines in |HyphenationMinikin::lastHyphenLocation|,
but the test isn't small. The hyphenation engine loads dictionaries
using a mojo service, but since the mojo service is not available in
unit tests, the test creates the engine from the dictionary file it
loaded.

BUG=692094

Review-Url: https://codereview.chromium.org/2692233005
Cr-Commit-Position: refs/heads/master@{#451519}
(cherry picked from commit dd1e643)

Review-Url: https://codereview.chromium.org/2713553007 .
Cr-Commit-Position: refs/branch-heads/2987@{#659}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
…bute usage

We need to analysis which sites are using autoplay muted by attribute.
This CL adds rappor metrics to record the eTLD+1 of the child frame and
top-level frame.

BUG=693889

Review-Url: https://codereview.chromium.org/2706593002
Cr-Commit-Position: refs/heads/master@{#452010}
(cherry picked from commit d0698b2)

Review-Url: https://codereview.chromium.org/2709013006 .
Cr-Commit-Position: refs/branch-heads/2987@{#660}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
In the cl https://codereview.chromium.org/2618383003/,
"set_separator_visibility to false" is called for all trays
that the separator is missing on the right side. I forget to
set it for the overview_tray.

TEST=MANUAL

BUG=692374

Review-Url: https://codereview.chromium.org/2702583002
Cr-Commit-Position: refs/heads/master@{#451514}
(cherry picked from commit c8cc142)

Review-Url: https://codereview.chromium.org/2703393011 .
Cr-Commit-Position: refs/branch-heads/2987@{#661}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#662}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
…for MSE."

The counts can be inferred by the sample volume for UnderflowDuration,
so there's no need to track both.

BUG=641633
TEST=manually checked histograms in chrome://histograms.

Review-Url: https://codereview.chromium.org/2707973005
Cr-Commit-Position: refs/heads/master@{#452113}
(cherry picked from commit 4f6d14d)

Review-Url: https://codereview.chromium.org/2713883003 .
Cr-Commit-Position: refs/branch-heads/2987@{#663}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Conceptually similar to the code removed in https://codereview.chromium.org/2594543004
but now takes padding into account so that the arrow isn't offset.

BUG=687079

Review-Url: https://codereview.chromium.org/2706273004
Cr-Commit-Position: refs/heads/master@{#452160}
(cherry picked from commit ac719a4)

Review-Url: https://codereview.chromium.org/2716503005 .
Cr-Commit-Position: refs/branch-heads/2987@{#664}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Allow inline install for user initiated fullscreen mode since this
mode requires that the user initiate it and due to a nuance with mac
windows where the green maximize button enters fullscreen.

BUG=690523

Review-Url: https://codereview.chromium.org/2693183002
Cr-Commit-Position: refs/heads/master@{#450753}
(cherry picked from commit e6d00f1)

Review-Url: https://codereview.chromium.org/2716693002 .
Cr-Commit-Position: refs/branch-heads/2987@{#665}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
…rd navigation.'

Cherry-picked patchset nwjs#1 and nwjs#2 from cl/2691693002

BUG=688047, 677356
Review-Url: https://codereview.chromium.org/2685803002
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2711123004
Cr-Commit-Position: refs/branch-heads/2987@{#666}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
I.e., how many players completed preload but never saw playback. This
will be handy in terms of guiding efforts to reduce the number of these
types of "useless" players. I.e. maybe deferred offscreen loading, etc.

BUG=694855
TEST=manual

Review-Url: https://codereview.chromium.org/2709903002
Cr-Commit-Position: refs/heads/master@{#452135}
(cherry picked from commit 35848da5131b081ee4751be9669230223baf7c43)

Review-Url: https://codereview.chromium.org/2711803006 .
Cr-Commit-Position: refs/branch-heads/2987@{#667}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
This is important in order to avoid exposing detached WebFrames through the blink public API.

BUG=691012

Review-Url: https://codereview.chromium.org/2706963004
Cr-Commit-Position: refs/heads/master@{#452079}
(cherry picked from commit ba0384c)

NOTRY=true
NOPRESUBMIT=true
TBR=dcheng@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2713963002
Cr-Commit-Position: refs/branch-heads/2987@{#668}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
In this change, we examine the error code returned when one of the P2P channels
is closed.  If no error is reported, then we pass OK to the error callback,
otherwise we convert to CHANNEL_CONNECTION_ERROR as before.

I am looking into the correct long-term fix for the session-terminate message
being dropped, however this change should be safer and can be merged into our
M57 release to allow us to correct the incorrect logging errors sooner.

BUG=692165

Review-Url: https://codereview.chromium.org/2708263002
Cr-Commit-Position: refs/heads/master@{#451912}
(cherry picked from commit 92f2a8c)

Review-Url: https://codereview.chromium.org/2715833002 .
Cr-Commit-Position: refs/branch-heads/2987@{#669}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Fix a crash due to reentrancy in the widget while processing a theme changed notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail. This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217)

Review-Url: https://codereview.chromium.org/2711853004
Cr-Commit-Position: refs/branch-heads/2987@{#670}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
chrome-cron and others added 12 commits March 26, 2017 00:16
Cr-Commit-Position: refs/branch-heads/2987@{#879}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#880}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
BUG=694382,698622

Review-Url: https://codereview.chromium.org/2742853003
Cr-Commit-Position: refs/heads/master@{#457363}
(cherry picked from commit 746da1c)

Review-Url: https://codereview.chromium.org/2775133002 .
Cr-Commit-Position: refs/branch-heads/2987@{#881}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Merge to M57.

BUG=704783

Review-Url: https://codereview.chromium.org/2775893002
Cr-Commit-Position: refs/heads/master@{#459554}
(cherry picked from commit e5d0b0e)

Review-Url: https://codereview.chromium.org/2780653002 .
Cr-Commit-Position: refs/branch-heads/2987@{#882}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#883}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#884}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
node-set is polymorphic; if called with a string, it returns a
node-set containing a text node with that content. The libxslt roll in
r425586 broke this behavior because Blink's fork of the node-set
extension returned a text node without an owner document. Fix that.

BUG=689977

Review-Url: https://codereview.chromium.org/2750943004
Cr-Commit-Position: refs/heads/master@{#457692}
(cherry picked from commit 3f6e482)

Review-Url: https://codereview.chromium.org/2784623002 .
Cr-Commit-Position: refs/branch-heads/2987@{#885}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#886}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
Cr-Commit-Position: refs/branch-heads/2987@{#887}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
The default background color of window is white, a flash of white
will be shown if the loaded page uses a dark background. So add a new
property named background_color to CreateWindowOptions that can be configured
the same as page dark background instead of white default color.
@fujunwei fujunwei force-pushed the background-color branch from 1cbf0e9 to ba8fdd2 Compare May 24, 2017 06:12
@rogerwang
Copy link
Member

Why do you submit a duplicate PR of #70 ?

@rogerwang rogerwang closed this May 25, 2017
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
TBR=lesliewatkins@chromium.org

(cherry picked from commit b15287c)

Bug: 672263, 673874, 746107
Change-Id: I5a1f7a4d86307bd84e236dc29d3da224abdcaef4
Reviewed-on: https://chromium-review.googlesource.com/580406
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488770}
Reviewed-on: https://chromium-review.googlesource.com/590088
Cr-Commit-Position: refs/branch-heads/3163@{#82}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Network thread shutdown may sometimes leak entries in Cronet environment,
and blocking-forever further creation for that cache path is inappropriate.
Further, the feature is mostly meant for other kinds of caches, which
get destroyed and created repeatedly.

TBR=morlovich@chromium.org

(cherry picked from commit b802d19)

Bug: 761331
Change-Id: Id0edd1cb3bda41723ea159a02a0d92a661e3f6e4
Reviewed-on: https://chromium-review.googlesource.com/648286
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499715}
Reviewed-on: https://chromium-review.googlesource.com/656617
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#82}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
hujiajie pushed a commit to hujiajie/chromium.src that referenced this pull request Sep 14, 2017
Port the standard changes in
whatwg/streams#721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
whatwg/streams@e7bf929.

The version of this CL merged to M59 branch 3071 adds failing and time-out test
expectations since the tests on hte branch are now out-of-date with respect to
the implementation. See http://crbug.com/713664.

BUG=711254,684543

Review-Url: https://codereview.chromium.org/2823563002
Cr-Commit-Position: refs/heads/master@{#465498}
(cherry picked from commit 6703f4d)

Review-Url: https://codereview.chromium.org/2831763003 .
Cr-Commit-Position: refs/branch-heads/3071@{nwjs#82}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
If ARC is not enabled or assistant value prop is not
accepted, an "Enable" button will be shown and the
runtime flow will be launched if user clicks it.

BUG=b:65161403
TEST=manually test by:
  1. Disabling play store
  2. Clicking "Enable" button in assistant section.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7ffba0d8828a4b673504d77dd3512be28da241a5
Reviewed-on: https://chromium-review.googlesource.com/719599
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509877}(cherry picked from commit 48a302e)
Reviewed-on: https://chromium-review.googlesource.com/728466
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#82}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
…n::Paint

Currently we have shipped the CSSPaintAPI, but not CSSPaintAPIArguments.
As a result, we could skip parsing the arguments if we run chromium without
--enable-experimental-web-platform-features, then the |paint_arguments|
in the CSSPaintDefinition::Paint function becomes nullptr, and we will
hit a DCHECK.

To fix it, we always check whether it is nullptr or not in that function.
We added a unit test to ensure that it will never crash.

Bug: 803026, 804206
Change-Id: I7f4b46eea423768974c7ffb3cd691484b1ad683d
Reviewed-on: https://chromium-review.googlesource.com/879110
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531262}(cherry picked from commit 206454e)
Reviewed-on: https://chromium-review.googlesource.com/884553
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#82}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
TBR=dimu@chromium.org

Change-Id: Id2ec59949ad9e5bed3bcbb49c2da428a9d4a5621
Reviewed-on: https://chromium-review.googlesource.com/954463
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#82}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
This is allowing the user to use Tab and up/down keys to navigation
throughout the menu. It can also be closed using the Escape key.

This change also trap the focus inside the menu while it's visible and
make it so that hovenig an item will move the focus to it, like most
menus will do.

This is mostly for accessibility so users can interact with the
controls using only a keyboard. The change applies to both the overflow
menu and the text track list.

Bug: 821131
Change-Id: I22db341d0d55a8e3297b3c7a18c92331e296cd9e
Reviewed-on: https://chromium-review.googlesource.com/1013478
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551353}(cherry picked from commit 523243f)
Reviewed-on: https://chromium-review.googlesource.com/1017260
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#82}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
I've set up a finch field trial for this feature.
We don't have to modify this value manually anymore.

Bug: 776260, 846996
Change-Id: I6d4f5428c90393cfaf509bd5ae00dedb235f18f7
Reviewed-on: https://chromium-review.googlesource.com/1074627
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562329}(cherry picked from commit a23fc18)
Reviewed-on: https://chromium-review.googlesource.com/1082131
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#82}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
TBR=sczs@chromium.org

(cherry picked from commit a9b6730)

Bug: 865507
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I68feba19be76ca9e7b185073ac51111fe954e7ad
Reviewed-on: https://chromium-review.googlesource.com/1145684
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577026}
Reviewed-on: https://chromium-review.googlesource.com/1150519
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#82}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
This CL allows users to be included in the Unified Consent experiment,
regardless of their Desktop Identity Consistency state.

Screenshots:
https://drive.google.com/file/d/1B-rkxD3kPtdBw5toDYJGE-SWuO7PQULL/view?usp=sharing
https://drive.google.com/file/d/1W8elDHLNBLJ5rK8QpX1K0xocgoTNpTI6/view?usp=sharing
https://drive.google.com/file/d/1Abi8z1FPONLsuaErVgwkfFJdkeHT3o2c/view?usp=sharing


Bug: 873064
Change-Id: I27674fe5e6826aba605bbb9b3b4edb3938dc036f
Reviewed-on: https://chromium-review.googlesource.com/1169814
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588359}(cherry picked from commit fee3942)
Reviewed-on: https://chromium-review.googlesource.com/1209150
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#82}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Per feedback reports we have received, the disconnect window positioning
logic is frustrating for users who are providing remote support via Me2Me.
This CL updates the logic so that we only place the dialog in the center
of the screen until we see local user input.  At that point we honor the
placement of the dialog unless a monitor change event occurs.  At that
point we place it above the taskbar which is less obtrusive but still
visible.

Bug: 896026
Change-Id: Ib40155e8207aec5e3d653695718204194e34cd44
Reviewed-on: https://chromium-review.googlesource.com/c/1285450
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600226}(cherry picked from commit 18bb641)
Reviewed-on: https://chromium-review.googlesource.com/c/1286189
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#82}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
With Windows Japanese and Korean layouts, the OS returns
duplicate values so it appears that multiple keys return
the '\' char.

It should return the currency symbol (yen or won) instead
of the '\', but J and K codepage history means that
Windows will conveniently (or not) map these characters
to the backslash.

See:
https://web.archive.org/web/20131023080358/http://blogs.msdn.com:80/b/michkap/archive/2005/09/17/469941.aspx
for some history/background.

Bug: 910649
Change-Id: If27e4e46959fccd3da292365c521d7f3c4bb2a9b
Reviewed-on: https://chromium-review.googlesource.com/c/1356875
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612789}(cherry picked from commit 82ec099)
Reviewed-on: https://chromium-review.googlesource.com/c/1361658
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#82}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Rather than having a UAF when OperationID overflows instead overwrite
the old operation with the new one. Can still cause weirdness, but at
least won't result in UAF. Also update OperationID to uint64_t to
make sure we don't overflow to begin with.

TBR=mek@chromium.org

(cherry picked from commit b38064d)

Bug: 925864
Change-Id: Ifdf3fa0935ab5ea8802d91bba39601f02b0dbdc9
Reviewed-on: https://chromium-review.googlesource.com/c/1441498
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#627115}
Reviewed-on: https://chromium-review.googlesource.com/c/1447265
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#82}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
LazyReattachIfAttached would leave ComputedStyle in non-distributed
elements and cause the next recalc to mark elements outside of the flat
tree for layout tree attachment.

Bug: 932908
Change-Id: Ic5d0d55ed7105932d4c3ab5b6006776bd58355e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491610
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639456}(cherry picked from commit 928b1021da14055b7ca93f822f4c5151cf675bc8)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520670
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#82}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.