Drop support for EOL'd Ruby versions 2.6 and earlier #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops support for older Ruby versions which have reached end-of-life, so Octokit.rb will only work with Ruby 2.7, 3.0 and 3.1. Today, the gemspec claims to support v2.0 onwards, but in practice, only v2.3 onwards are tested in CI and actually working.
|
@nickfloyd The missing checks are okay as those versions are now dropped from the test matrix 😊 |
nickfloyd
reviewed
Jul 12, 2022
| os: [ ubuntu ] | ||
| ruby: [ 2.3, 2.4, 2.5, 2.6, 2.7, '3.0', '3.1', head ] | ||
| ruby: [ 2.7, '3.0', '3.1', head ] | ||
| faraday: [ '~> 1.0', '~> 2.0' ] |
There was a problem hiding this comment.
I am pretty sure we can get rid of the 1.0 reference here... Let me know if that sounds right.
Suggested change
| faraday: [ '~> 1.0', '~> 2.0' ] | |
| faraday: '~> 2.0' |
There was a problem hiding this comment.
We can still continue to support Faraday 1.x. Dropping support for Faraday 1.x is often pretty painful as there are lots of packages out there that still require it.
There was a problem hiding this comment.
I am pretty sure we can get rid of the 1.0 reference here... Let me know if that sounds right.
Suggested change
faraday: [ '~> 1.0', '~> 2.0' ] faraday: '~> 2.0'
This comment was marked as spam.
This comment was marked as spam.
koic
added a commit
to koic/octokit.rb
that referenced
this pull request
Feb 14, 2023
Follow up octokit#1454. gemspec `required_ruby_version` requires 2.7 and higher, so specify `TargetRubyVersion` to 2.7. Some syntax detected by updating to 2.7 applies. It also removes `Gemspec/RequiredRubyVersion` cop from .rubocop_todo.yml to enable the cop so that version mismatch can be detected.
5 tasks
kfcampbell
pushed a commit
that referenced
this pull request
Feb 27, 2023
Follow up #1454. gemspec `required_ruby_version` requires 2.7 and higher, so specify `TargetRubyVersion` to 2.7. Some syntax detected by updating to 2.7 applies. It also removes `Gemspec/RequiredRubyVersion` cop from .rubocop_todo.yml to enable the cop so that version mismatch can be detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for older Ruby versions which have reached end-of-life, so Octokit.rb will only work with Ruby 2.7, 3.0 and 3.1.
Today, the gemspec claims to support v2.0 onwards, but in practice, only v2.3 onwards are tested in CI and actually working.