KEMBAR78
Static L0 Loader Support by nrspruit · Pull Request #224 · oneapi-src/level-zero · GitHub
Skip to content

Conversation

@nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Oct 25, 2024

Static Loader Support.

This support has a few conditions:

  1. zes/ze driver split is not supported without this version of the loader so backwards compatibility for different lists of drivers for ze/zes init is not supported if using the static lib due to needing to modify the loader's context. zes/ze driver list will be the same.
  2. As of this version of the loader, all symbols read between the static loader and the dynamic loader must remain ABI compatible ie all apis exported in source/loader/ze_loader_api.h now must be abi compatible.
  3. The oldest dynamic loader supported is v1.15.17

Copy link
Contributor

@lisanna-dettwyler lisanna-dettwyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments from looking at it briefly

@nrspruit nrspruit changed the title [DO_NOT_MERGE] Static L0 Loader Support Static L0 Loader Support Nov 15, 2024
@nrspruit nrspruit requested a review from aravindksg November 15, 2024 19:59
@nrspruit nrspruit force-pushed the static_loader branch 2 times, most recently from 62860db to 0397704 Compare November 15, 2024 21:40
@ilya-lavrenov
Copy link
Contributor

Issue #141

@nrspruit nrspruit force-pushed the static_loader branch 2 times, most recently from 575a758 to faaa9e8 Compare January 27, 2025 19:30
@nrspruit nrspruit marked this pull request as ready for review January 27, 2025 22:10
@nrspruit nrspruit force-pushed the static_loader branch 4 times, most recently from aec89b8 to 399cd15 Compare February 11, 2025 21:30
@nrspruit nrspruit force-pushed the static_loader branch 2 times, most recently from 399cd15 to dc17e65 Compare February 14, 2025 21:46
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
- Added support for older dii tables such that the version of the apis
  supported by that dynamic loader are requested and not newer versions.
- Added check for backwards compatability for older init apis.

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
… loader build

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
…build

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit force-pushed the static_loader branch 4 times, most recently from 06a32ba to ad041c7 Compare February 20, 2025 16:05
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@rwmcguir
Copy link
Contributor

rwmcguir commented Feb 20, 2025

Looks good to me, as I have seen the testing output. Debating on if we need to increment minor here as part of this commit since it is a decent size feature add-on.

EDIT... I see this was just added..

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit merged commit 51dd3d8 into oneapi-src:master Feb 20, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants