Completable result code throwable #6348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
=========================================
Coverage 90.17% 90.17%
- Complexity 6259 6269 +10
=========================================
Files 697 697
Lines 18871 18890 +19
Branches 1843 1844 +1
=========================================
+ Hits 17016 17035 +19
Misses 1283 1283
Partials 572 572 ☔ View full report in Codecov by Sentry. |
|
Hi @jack-berg any updates on when this might be merged? I'd be happy to look into contributing with PRs to update the Http and Grpc exporters once this is merged (as discussed #6306 (comment)). Thanks. |
|
@jarrodrobins - I'm blocked on reviews / approvals from @open-telemetry/java-approvers. I review from you is helpful as well, but won't be able to merge without an approval from an approver. |
jkwatson
approved these changes
Aug 7, 2024
jaydeluca
approved these changes
Aug 7, 2024
…y-java into completable-result-code-throwable
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6306.
Discussed in the 3/28/24 Java SIG. Also need to adjust the behavior of HttpExporter and GrpcExporter (and potentially the related sender implementations) to fail CompletableResultCodes exceptionally. Planning on doing this in a followup PR, since there are details to work out about what the structure is with the failure exception.