Add support for setting OTLP exporter executor service #7152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7152 +/- ##
=========================================
Coverage 89.92% 89.92%
- Complexity 6662 6677 +15
=========================================
Files 750 750
Lines 20126 20173 +47
Branches 1973 1981 +8
=========================================
+ Hits 18098 18141 +43
- Misses 1434 1436 +2
- Partials 594 596 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
commented
Mar 3, 2025
...rs/sender/jdk/src/main/java/io/opentelemetry/exporter/sender/jdk/internal/JdkHttpSender.java
Outdated
Show resolved
Hide resolved
jack-berg
force-pushed
the
otlp-configurable-executor
branch
from
241666f to
15a1f3f
Compare
trask
approved these changes
Mar 12, 2025
Comment on lines
+239
to
+241
| * <p>NOTE: By calling this method, you are opting into managing the lifecycle of the {@code | ||
| * executorService}. {@link ExecutorService#shutdown()} will NOT be called when this exporter is | ||
| * shutdown. |
.../okhttp/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSender.java
Outdated
Show resolved
Hide resolved
.../okhttp/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSender.java
Outdated
Show resolved
Hide resolved
…y-java into otlp-configurable-executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6995.
Depends on #7151.