Propagate flush to PeriodicMetricReader's metricExporter. #7410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a synchronous exporter this doesn't matter, but the API design allows for asynchronous exporters, which requires calling flush after manually exporting. Fixes open-telemetry#7343
tylerbenson
commented
Jun 9, 2025
Comment on lines
84
to
98
| CompletableResultCode result = new CompletableResultCode(); | ||
| CompletableResultCode flushResult = scheduled.doRun(); | ||
| flushResult.whenComplete( | ||
| () -> | ||
| exporter | ||
| .flush() | ||
| .whenComplete( | ||
| () -> { | ||
| if (!flushResult.isSuccess()) { | ||
| result.fail(); | ||
| } else { | ||
| result.succeed(); | ||
| } | ||
| })); | ||
| return result; |
There was a problem hiding this comment.
I've seen this pattern in enough places I wonder if it would be worth adding CompletableResultCode.whenComplete(Callable<CompletableResultCode>) that handles this logic in one place.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7410 +/- ##
=========================================
Coverage 89.75% 89.76%
- Complexity 6981 6985 +4
=========================================
Files 797 797
Lines 21165 21175 +10
Branches 2057 2057
=========================================
+ Hits 18997 19007 +10
+ Misses 1505 1504 -1
- Partials 663 664 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Thanks!
Also, this behavior is indeed explicitly called out in the spec: https://github.com/open-telemetry/opentelemetry-specification/blame/18a37a1ed8dff267e72824fa066d9d46dbaede7e/specification/metrics/sdk.md#L1436-L1443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a synchronous exporter this doesn't matter, but the API design allows for asynchronous exporters, which requires calling flush after manually exporting.
Fixes #7343