📖 Rephrased the CI-Test description. #4708
Conversation
|
Hey @spencerschrock, we noticed that you were working on this issue before and were wondering if you could give us any feedback |
There was a problem hiding this comment.
Generally looks good, thanks for following the CONTRIBUTING.md
Hey @spencerschrock, we noticed that you were working on this issue before and were wondering if you could give us any feedback
Of course! I am currently focused on other tasks, but will try to fit this in when I can.
|
Hey, thank you for the reply @spencerschrock . We’ve made the recommended changes to the commit. |
Please re-run |
kailealee
requested review from
justaugustus and
raghavkaul
and removed request for
a team
|
Thank you @spencerschrock, we ran generate-docs and committed the resulting files. |
Unfortunately, the DCO check is failing and will need to be fixed. |
Co-authored-by: Kaylee Williams <kaylee.williams@sus.edu> Co-authored-by: Denzel Caine <d.caine@spartans.nsu.edu> Co-authored-by: Jakiya Brown <2005kiyabrown@gmail.com> Co-authored-by: Devon Bobo <devon3583@gmail.com> Co-authored-by: Kemon Bynum <monbynum51@icloud.com> Co-authored-by: Silas Morgan <victorsmorgan@gmail.com> Co-authored-by: Jordin Jones <j.a.jones107732@spartans.nsu.edu> Signed-off-by: Kailea Lee <kaileaalee99@gmail.com>
Signed-off-by: Kailea Lee <kaileaalee99@gmail.com>
Signed-off-by: Kailea Lee <kaileaalee99@gmail.com>
kailealee
force-pushed
the
test-description
branch
from
0eb66da to
ab958c9
Compare
|
Hello @spencerschrock, I believe I’ve fixed the DCO check. Please let me know if anything else is needed. |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4708 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.49%
==========================================
Files 230 249 +19
Lines 16602 18925 +2323
==========================================
+ Hits 11091 12925 +1834
- Misses 4808 5137 +329
- Partials 703 863 +160 🚀 New features to boost your workflow:
|
3 participants
What kind of change does this PR introduce?
Documentation Update: Fix CI-Test description in file
docs/checks/internal/checks.yamlas per Spencers Suggestions.What is the current behavior?
What is the new behavior (if this is a feature change)?**
N/A
Which issue(s) this PR fixes
Fixes #3616
Special notes for your reviewer
This pr builds on PR #4275. As such we've co-authored the individuals that worked on that PR.
I worked on this PR with @purpleskates123, @jakbrownbytes, @dcaine125, @SilasVM, and @devon3583.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)