-
-
Notifications
You must be signed in to change notification settings - Fork 193
Comparing changes
Open a pull request
base repository: passwordless-lib/fido2-net-lib
base: 4.0.0-beta.13
head repository: passwordless-lib/fido2-net-lib
compare: 4.0.0-beta.14
- 8 commits
- 170 files changed
- 6 contributors
Commits on Jul 16, 2024
-
Resolve StoredCredential.Descriptor at access(?) (#528)
* Just resolve the descriptor at runtime * Missing ; * Update StoredCredential.cs
Configuration menu - View commit details
-
Copy full SHA for 184f70f - Browse repository at this point
Copy the full SHA 184f70fView commit details -
Remove base-class, Status and ErrorMessage (#529)
* Remove base-class * Removed usage of Status/ErrorMessage in tests * Rename MakeNewCredentialResult.Result to .Credential * format * Removed MakeNewCredentialResult * fixed after rebase * Passes conformance tests * undo local changes * small fix * small fix
Configuration menu - View commit details
-
Copy full SHA for cb71a15 - Browse repository at this point
Copy the full SHA cb71a15View commit details
Commits on Oct 4, 2024
-
Update MetadataStatement to include friendly names (#544)
* Update MetadataStatement to include friendly names * Fix file encoding * Update MetadataStatement.cs * Fix alternativeDescriptions --------- Co-authored-by: joegoldman2 <147369450+joegoldman@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 26e5f75 - Browse repository at this point
Copy the full SHA 26e5f75View commit details
Commits on Oct 18, 2024
-
This PR does not reach full conformance testing score because of #554, but sets the bed nicely for reaching conformance. * FIDO Conformance Tools v1.7.15 fixes TrustAnchor.cs : 32 Server-ServerAuthenticatorAttestationResponse-Resp-5 Test server processing "packed" FULL attestation F-10 Send ServerAuthenticatorAttestationResponse with FULL "packed" attestation, with attStmt.x5c containing full chain, and check that server returns an error https://datatracker.ietf.org/doc/html/rfc5280#section-6.1 AuthenticatorAttestationRawResponse.cs : 18 Server-ServerAuthenticatorAttestationResponse-Resp-1 Test server processing ServerAuthenticatorAttestationResponse structure F-4 Send ServerAuthenticatorAttestationResponse that is missing "type" field and check that server returns an error CredentialCreateOptions.cs : 96 Server-ServerAuthenticatorAttestationResponse-Resp-4 Test server support of the authentication algorithms P-8 Send a valid ServerAuthenticatorAttestationResponse with SELF "packed" attestation, for "ALG_SIGN_RSASSA_PKCSV15_SHA1_RAW" aka "RS1" algorithm, and check that server succeeds Server-ServerAuthenticatorAttestationResponse-Resp-9 Test server processing "tpm" attestation P-2 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation for SHA-1, and check that server succeeds CredentialCreateOptions.cs : 210 Server-ServerPublicKeyCredentialCreationOptions-Req-1 Test server generating ServerPublicKeyCredentialCreationOptionsRequest P-1 Get ServerPublicKeyCredentialCreationOptionsResponse, and check that: (a) response MUST contain ... AuthenticationExtensionsClientInputs.cs : 23 public string AppID { private get; set; } Server-ServerPublicKeyCredentialGetOptionsResponse-Req-1 Test server generating ServerPublicKeyCredentialGetOptionsResponse P-1 Get ServerPublicKeyCredentialGetOptionsResponse, and check that: (a) response MUST contain ... AuthenticationExtensionsClientInputs.cs : 44 public bool? UserVerificationMethod { private get; set; } Server-ServerPublicKeyCredentialGetOptionsResponse-Req-1 Test server generating ServerPublicKeyCredentialGetOptionsResponse P-1 Get ServerPublicKeyCredentialGetOptionsResponse, and check that: (a) response MUST contain ... AuthenticatorAssertionResponse.cs : 128 Server-ServerAuthenticatorAssertionResponse-Resp-3 P4,P6,P7 CryptoUtils.cs 64 (trustpath length 1 with exact match in attestation root certs) Server-ServerAuthenticatorAttestationResponse-Resp-5 Test server processing "packed" FULL attestation P-3 Send a valid ServerAuthenticatorAttestationResponse with FULL "packed" attestation that contains batch certificate, that is simply self referenced in the metadata, and check that server succeeds CryptoUtils.cs 105 - X509RevocationMode.Online makes conformance sad Server-ServerAuthenticatorAttestationResponse-Resp-9 Test server processing "tpm" attestation P-1 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation for SHA-256, and check that server succeeds‣ P-2 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation for SHA-1, and check that server succeeds‣ P-3 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation pubArea.nameAlg is not matching algorithm used for generate attested.name, and check that server succeeds TestController.cs tojson -> serialize serialization error * Json serialization fix Json serialization fix. (Object type vs ToJson()) * Unit test fix * tokenbindig, AppId, UVP Back to 100% conformance. TokenBinding logic readded. AppId: prevent serialization in a nicer way. UV flags are verified differently for conformance testing, otherwise as described in the RFC. * unit test fix (tokenbinding dto parsing) * fix azure pipeline fix azure pipeline's whitespace error + removing unused using * Improve trustanchor test coverage Improve trustanchor test coverage based on codecov report * TestPackedttestationAsyncFailTrustAnchorOnRootCertInTrustPath only works on Windows * Do not make this private * Keep Tokenbinding around * Update AuthenticatorAssertionResponse.cs * Added XML comments to requestTokenBinding * Added comment about UVM * Simplify UVP * format * Reverting some changes (#554) I'm keeping these around until we've understood if we really can drop them * Ignores Demo/Conformance * Refactored away from bool to enum. * File based namespace * format --------- Co-authored-by: Gabor Mihaly <Gabor.Mihaly@lastpass.com> Co-authored-by: googyi <mgoogyi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f9f0cb - Browse repository at this point
Copy the full SHA 0f9f0cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea57fd - Browse repository at this point
Copy the full SHA 0ea57fdView commit details -
Move Test folder to Tests/Fido2.Tests (#549)
* Move Test folder to Tests/Fido2.Tests * Fix CI * dotnet format --------- Co-authored-by: joegoldman2 <147369450+joegoldman@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 455f428 - Browse repository at this point
Copy the full SHA 455f428View commit details
Commits on Oct 28, 2024
-
* Various cleanup * dotnet format --------- Co-authored-by: joegoldman2 <147369450+joegoldman@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 72f5a36 - Browse repository at this point
Copy the full SHA 72f5a36View commit details -
Wrap arguments into classes (#556)
* Wrap method arguments into classes * format * format * Seal the classes * Adress feedback
Configuration menu - View commit details
-
Copy full SHA for b2e7c15 - Browse repository at this point
Copy the full SHA b2e7c15View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.0.0-beta.13...4.0.0-beta.14