KEMBAR78
Sparteo Bid Adapter: add Outstream support with custom video renderer, configured by bidResponse by jperquy-sparteo · Pull Request #13512 · prebid/Prebid.js · GitHub
Skip to content

Conversation

jperquy-sparteo
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Sparteo Bid Adapter update: add Outstream support to Sparteo by implementing a custom video renderer (in case it is not provided by the publisher in page). Video renderer configured is retrieved from bidResponse.

There is no Api change and no specific configuration required from publishers -> no documentation updates

@jperquy-sparteo jperquy-sparteo force-pushed the sparteo-bidadapter-outstream-video-renderer branch from 2ca4236 to 833d507 Compare July 4, 2025 09:10
@ChrisHuie ChrisHuie requested a review from osazos July 7, 2025 14:12
@jperquy-sparteo jperquy-sparteo force-pushed the sparteo-bidadapter-outstream-video-renderer branch from 833d507 to 681e3f1 Compare July 15, 2025 12:13
@jperquy-sparteo
Copy link
Contributor Author

@osazos : do you have an idea how I can make the e2e tests to pass? they always break on browserstack.
I didn't modified e2e tests, and I don't think my modification can have an impact on browserstack.

@jperquy-sparteo
Copy link
Contributor Author

@osazos : please, can you review my PR ?

@jperquy-sparteo jperquy-sparteo force-pushed the sparteo-bidadapter-outstream-video-renderer branch from 2fbb30c to f463e5a Compare July 31, 2025 14:52
@jperquy-sparteo
Copy link
Contributor Author

@osazos : I need this PR to be reviewed. Is there anything I should do to help you in the process ?

@ChrisHuie ChrisHuie requested review from ChrisHuie and removed request for osazos August 15, 2025 16:38
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned osazos Aug 15, 2025
@ChrisHuie
Copy link
Collaborator

@osazos : I need this PR to be reviewed. Is there anything I should do to help you in the process ?

I will take a look at this pr and try to get it merged before the next release

@ChrisHuie
Copy link
Collaborator

looks good. Can you pull in master because this pr is a little behind and want to make sure it works with recent updates

@jperquy-sparteo jperquy-sparteo force-pushed the sparteo-bidadapter-outstream-video-renderer branch from f463e5a to f545d03 Compare August 22, 2025 12:48
@ChrisHuie ChrisHuie merged commit a638298 into prebid:master Aug 23, 2025
20 checks passed
@jperquy-sparteo jperquy-sparteo deleted the sparteo-bidadapter-outstream-video-renderer branch August 25, 2025 07:48
@jperquy-sparteo
Copy link
Contributor Author

@ChrisHuie Thanks !

iamumarr added a commit to media-net/Prebid.js that referenced this pull request Sep 1, 2025
…use pbjs.getUserIds instead of bid.userid

use getUserIds instead of bid.userId

Log WebServer Ip and Data Center from PBS Logs

Pass Ext in Response.seatBid

Fixed ext Type

Send PBS ext to all bidders

Send Ext Fields in Pbsext incase of Prebid Server

Refactored Some changes

Formatting Done

Remove Unused import - linter failing

Bump @babel/core from 7.28.0 to 7.28.3 (prebid#13780)

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.28.0 to 7.28.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.28.3/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-version: 7.28.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump fs-extra from 11.3.0 to 11.3.1 (prebid#13777)

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 11.3.0 to 11.3.1.
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](jprichardson/node-fs-extra@11.3.0...11.3.1)

---
updated-dependencies:
- dependency-name: fs-extra
  dependency-version: 11.3.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Core: temporary lock on targeting (prebid#13722)

* ttlCollection: add has, delete methods

* targeting lock

* fix tests

* remove unused fn

* Fix tests

* Fix tsdoc

appStockSSP Bid Adapter : initial release (prebid#13673)

* init appStockSSPBidAdapter

* region east update

* fix unit tests

* review updates

---------

Co-authored-by: Kanceliarenko <kostiantyn.k@teqblaze.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

Bridgewell Bid Adapter: adopt userIdAsEids (prebid#13785)

* Adopt userIdAsEids in bridgewellBidAdapter

* Add userIdAsEids to tests of bridgewellBidAdapter

---------

Co-authored-by: piano <piano@bridgewell.com>

Ozone Bid Adapter : fix for undefined userIdAsEids  (prebid#13784)

* Update ozoneBidAdapter.js

bug fix in findAllUserIdsFromEids when bid.userIdAsEids is set but not an array (eg null)

* Update ozoneBidAdapter_spec.js

spec test updated for bugfix

* Update ozoneBidAdapter_spec.js

* Update ozoneBidAdapter.js

* Update ozoneBidAdapter.js

revert let to const

* Update ozoneBidAdapter_spec.js

Adipolo Bid Adapter: add endpoint for eu region (prebid#13788)

* add gvlid

* add gvlid

* add gvlid

* add eu region

* add test to eu region

* refactor(adipolo): safely fallback to default endpoint if region is unknown

* add tests to invalid and undefined region

* detect region via timezone for endpoint selection

Core: timeoutQueue to TS (prebid#13469)

* libraries: optimize timeoutQueue implementation

* libraries: convert timeoutqueue to typescript

* Delete libraries/timeoutQueue/timeoutQueue.js

Scope3 RTD Provider: Add agentic execution engine module (prebid#13781)

* first cut at a scope3 rtd module

* Scope3 RTD Module: Major improvements for agentic execution engine

- Changed from carbon scoring to agentic execution engine (AEE) for real-time media buying
- Now sends COMPLETE OpenRTB request preserving all existing data via deep copy
- Changed publisherId to orgId and removed API key requirement for client-side use
- Updated endpoint to https://prebid.scope3.com/prebid
- Added configurable targeting keys (includeKey, excludeKey, macroKey) for GAM
- Implemented bidder-specific segments using standard OpenRTB user.data format
- Added deal ID support at impression level (ortb2Imp.ext)
- Sends list of bidders to Scope3 (defaults to all bidders in auction)
- Fixed data preservation issue in extractOrtb2Data function
- Updated response format to handle aee_signals structure
- Comprehensive documentation updates with integration examples

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix ESLint issues in Scope3 RTD Provider tests

- Remove trailing spaces on lines 126, 140, and 302
- Add missing newline at end of file

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Convert Scope3 RTD module to TypeScript

Per maintainer feedback, converted the module to TypeScript:
- Converted scope3RtdProvider.js to scope3RtdProvider.ts
- Added proper TypeScript type declarations
- Fixed module registration in .submodules.json (not modules.json)
- All 13 tests still passing
- Module builds successfully (4.22KB minified)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix ESLint issues in TypeScript module

- Removed unused imports (isPlainObject, mergeDeep, AllConsentData)
- Removed unused STORAGE_KEY constant
- All linting checks now pass
- All 13 tests still passing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Address PR reviewer feedback

- Use GAM-compliant segment names (short codes like 'x82s', 'a91k')
- Remove underscores from examples (GAM doesn't allow them)
- Document that Scope3 uses brand-specific short codes, not IAB taxonomy
- Add more tests to improve coverage (now 19 tests, targeting 90%)
- Fix test failures and improve error handling coverage
- Update documentation to clarify segment format and privacy benefits

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Remove modules.json - RTD modules only need .submodules.json

Per reviewer feedback, RTD modules should only be registered in
modules/.submodules.json, not in a separate modules.json file.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Clarify agent signals are line item targeting instructions

Per reviewer feedback, corrected documentation to accurately describe that:
- Signals are instructions for GAM line item targeting (include/exclude)
- NOT buy/sell decisions or audience segments
- Codes like 'x82s' mean "include this impression in this line item"
- Macro provides data that can be used in creatives

The agent provides targeting instructions that control which line items
can serve on each impression.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix ESLint trailing spaces in test file

- Removed trailing spaces from lines 376, 378, 382, 399, 403, 406, 442
- All ESLint checks now pass
- All 19 tests still passing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix GAM-incompatible base64 examples in documentation

- Replace base64 encoded macro values with GAM-compliant alphanumeric codes
- Remove '=' characters and mixed case that GAM doesn't support
- Update bidder integration example to treat macro as opaque string
- All targeting values now use only lowercase letters and numbers

* Improve segment data compatibility and add AppNexus support

- Add segments to multiple locations: site.ext.data.s3kw and site.content.data
- Use proper OpenRTB segtax format (segtax: 600) for vendor-specific taxonomy
- Add AppNexus-specific keyword conversion (s3_seg=value format)
- Segments now available in standard locations for broader bidder compatibility
- Update tests to verify new data structures

* Update segtax ID to 604 for Scope3 AEE Targeting Signals

- Change from generic 600 to specific 604 for Scope3
- Add comment indicating pending registration with IAB
- Update all tests to use new segtax ID
- Prepare for OpenRTB segtax registration PR

* Update to official segtax ID 3333 per IAB OpenRTB PR

- Change segtax from 604 to 3333 as registered in IAB OpenRTB PR prebid#201
- Update all references in code and tests
- Run linter fixes on all files
- Tests passing with new segtax ID

* Fix module name to 'scope3' and enhance debug logging

- Change module name from 'scope3RtdProvider' to 'scope3' to match documentation
- Add enhanced debug logging to help diagnose configuration issues
- Update TypeScript types to match the correct module name
- Fix test assertion to match new error message format
- All tests passing (20/20)

* Update default endpoint to rtdp.scope3.com/prebid

- Change default endpoint from prebid.scope3.com to rtdp.scope3.com
- Update all tests to use new endpoint
- Remove staging endpoint example from documentation
- All tests passing (20/20)

* Revert endpoint back to prebid.scope3.com/prebid

- Change default endpoint back to prebid.scope3.com/prebid
- Update all tests and documentation to match
- All tests passing (20/20)

---------

Co-authored-by: Claude <noreply@anthropic.com>

adplusIdSystem: fix flaky test (prebid#13793)

Bump babel-loader from 8.3.0 to 8.4.1 (prebid#13778)

Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.3.0 to 8.4.1.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.3.0...v8.4.1)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-version: 8.4.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick McCann <pmccann@cafemedia.com>

Bump @wdio/cli from 9.18.4 to 9.19.1 (prebid#13779)

Bumps [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) from 9.18.4 to 9.19.1.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.19.1/packages/wdio-cli)

---
updated-dependencies:
- dependency-name: "@wdio/cli"
  dependency-version: 9.19.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

Sparteo Bid Adapter: add Outstream support with custom video renderer, configured by bidResponse (prebid#13512)

Bump @wdio/browserstack-service from 9.15.0 to 9.19.1 (prebid#13776)

Bumps [@wdio/browserstack-service](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-browserstack-service) from 9.15.0 to 9.19.1.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.19.1/packages/wdio-browserstack-service)

---
updated-dependencies:
- dependency-name: "@wdio/browserstack-service"
  dependency-version: 9.19.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Datawrkz Analytics Adapter :  initial release (prebid#13738)

* feat(analytics): added Datawrkz analytics adapter

* fix(analytics): lint fixes for Datawrkz Analytics Adapter

* fix(analytics): lint fixes for Datawrkz Analytics Adapter

---------

Co-authored-by: Monis Qadri <monis0395@users.noreply.github.com>

fixed typos end changed test endpoint (prebid#13794)

ID5 ID module: enable shared storage across multiple partners (prebid#13768)

Bump karma from 6.4.3 to 6.4.4 (prebid#13803)

Bumps [karma](https://github.com/karma-runner/karma) from 6.4.3 to 6.4.4.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](karma-runner/karma@v6.4.3...v6.4.4)

---
updated-dependencies:
- dependency-name: karma
  dependency-version: 6.4.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump core-js from 3.45.0 to 3.45.1 (prebid#13806)

Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.45.0 to 3.45.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.45.1/packages/core-js)

---
updated-dependencies:
- dependency-name: core-js
  dependency-version: 3.45.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add gvlid type to BidderSpec (prebid#13796)

PubMatic Adapters : refactored publisher id, profile id and version id (prebid#13747)

* Refactored publisher id, profile id and version id

* Update pubmaticAnalyticsAdapter.js

* resolved conflicts for refactoring

Core: make transaction IDs bidder-specific (prebid#13800)

* Bidder specific TIDs

* force adapters to use bidder-specific TIDs

* fix tests

revnew alias added (prebid#13808)

Co-authored-by: Gabriel Chicoye <gabriel@macbookrogab24g.lan>

Bump @babel/runtime from 7.27.6 to 7.28.3 (prebid#13805)

Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.27.6 to 7.28.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.28.3/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-version: 7.28.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump webdriver from 9.15.0 to 9.19.2 (prebid#13804)

Bumps [webdriver](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/webdriver) from 9.15.0 to 9.19.2.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.19.2/packages/webdriver)

---
updated-dependencies:
- dependency-name: webdriver
  dependency-version: 9.19.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump @wdio/spec-reporter from 8.38.2 to 8.43.0 (prebid#13810)

Bumps [@wdio/spec-reporter](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-spec-reporter) from 8.38.2 to 8.43.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/v8.43.0/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.43.0/packages/wdio-spec-reporter)

---
updated-dependencies:
- dependency-name: "@wdio/spec-reporter"
  dependency-version: 8.43.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump @babel/register from 7.24.6 to 7.28.3 (prebid#13811)

Bumps [@babel/register](https://github.com/babel/babel/tree/HEAD/packages/babel-register) from 7.24.6 to 7.28.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.28.3/packages/babel-register)

---
updated-dependencies:
- dependency-name: "@babel/register"
  dependency-version: 7.28.3
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump globals from 16.0.0 to 16.3.0 (prebid#13802)

Bumps [globals](https://github.com/sindresorhus/globals) from 16.0.0 to 16.3.0.
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v16.0.0...v16.3.0)

---
updated-dependencies:
- dependency-name: globals
  dependency-version: 16.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

Prebid 10.9.0 release

Increment version to 10.10.0-pre

Waardex Bid Adapter: Update endpoint domain (prebid#13812)

* Update endpoint domain in waardexBidAdapter

* Fix conflicts

---------

Co-authored-by: Yegor Serdiuk <yegorheiz@gmail.com>

Fwssp Bid Adapter : add currency to bidfloor (prebid#13801)

* Update fwsspBidAdapter.js

Update to use floor() for currency

* Update fwsspBidAdapter_spec.js

To use floor() for currency

VISX Bid Adapter: Updated values of creativeId and advertiserDomains (prebid#13820)

Build system: add schema-utils dependency (prebid#13821)

Revert vast tracker error changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants