bazel: add missing rules_cc loads #23584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for use with bazel after this commit bazelbuild/bazel@71ca0ed Many files have these already
keith
requested review from
JasonLunn,
anandolee and
shaod2
and removed request for
a team
|
Could this be included in the next minor release? |
zhangskz
approved these changes
Oct 3, 2025
github-actions
bot
removed
the
🅰️ safe for tests
|
Looks like this will be needed for Bazel 9 support which is released in November so likely won't officially support until at least v34.0. We just cut v33.0-RC1, but I think this seems reasonable to include in v33.0 anyways. |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
This is required for use with bazel after this commit bazelbuild/bazel@71ca0ed Many files have these already Closes #23584 COPYBARA_INTEGRATE_REVIEW=#23584 from keith:ks/bazel-add-missing-rules_cc-loads 733a0cc FUTURE_COPYBARA_INTEGRATE_REVIEW=#23584 from keith:ks/bazel-add-missing-rules_cc-loads 733a0cc PiperOrigin-RevId: 817800800
mkruskal-google
pushed a commit
that referenced
this pull request
Oct 13, 2025
This is required for use with bazel after this commit bazelbuild/bazel@71ca0ed Many files have these already Closes #23584 COPYBARA_INTEGRATE_REVIEW=#23584 from keith:ks/bazel-add-missing-rules_cc-loads 733a0cc PiperOrigin-RevId: 817836399
mkruskal-google
added a commit
that referenced
this pull request
Oct 13, 2025
bazel: add missing rules_cc loads (#23584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for use with bazel after this commit bazelbuild/bazel@71ca0ed
Many files have these already