Add a with_config decorator to comply with typing spec
#8611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #8611 will not alter performanceComparing Summary
|
sydney-runkle
suggested changes
Jan 23, 2024
There was a problem hiding this comment.
Hey @Viicos,
@dmontagu and I really like this approach. A few notes:
It'd be great if this could also be used with dataclasses. I think as it stands, it can, but you just haven't documented it yet. A few requests for changes (I know you wanted to get this approved before working on additional docs):
- Docs update with a vanilla example for both
dataclassandTypedDict. Docs in both the "Concepts" section and "API Documentation" section (via docstrings) would be fantastic. mypytests with this new decorator, as a proof of concept for how this fixes the original issue.
Thanks a bunch for your work on this - it'll be a great feature to have :).
pydantic-hooky
bot
added
the
awaiting author revision
|
Please review |
pydantic-hooky
bot
added
ready for review
and removed
awaiting author revision
Viicos
force-pushed
the
with-config-decorator
branch
from
edaa36b to
d28b239
Compare
Viicos
force-pushed
the
with-config-decorator
branch
from
d28b239 to
645f7f8
Compare
sydney-runkle
suggested changes
Jan 24, 2024
pydantic-hooky
bot
added
awaiting author revision
|
I've moved the attached issue into the 2.7.0 milestone :). |
Viicos
force-pushed
the
with-config-decorator
branch
from
867bbbb to
1087ab1
Compare
Viicos
force-pushed
the
with-config-decorator
branch
from
1087ab1 to
7daacab
Compare
|
Amazing work 🚀. Merging this now to be included in 2.7.0! |
sydney-runkle
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #8514, as suggested in a comment.
If accepted, better documentation will follow
Selected Reviewer: @dmontagu