Handle __pydantic_extra__ annotation being a string or inherited
#8659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
changed the title
__pydantic_extra__ annotation being a string or inherited
CodSpeed Performance ReportMerging #8659 will not alter performanceComparing Summary
|
adriangb
approved these changes
Jan 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Evaluates
__pydantic_extra__to an actual type when it's a string, e.g. because offrom __future__ import annotations.Also fixes another bug in that area: the loop
for tp in (cls, *cls.__mro__):didn't use the variabletpso the annotation was not checked on parent classes.Related issue number
Closes #8647
Checklist