KEMBAR78
fixes __pydantic_config__ ignored for TypeDict by 13sin · Pull Request #8734 · pydantic/pydantic · GitHub
Skip to content

fixes __pydantic_config__ ignored for TypeDict #8734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2024
Merged

fixes __pydantic_config__ ignored for TypeDict #8734

merged 1 commit into from
Feb 6, 2024

Conversation

@13sin
Copy link
Contributor

@13sin 13sin commented Feb 6, 2024 •
edited
Loading

Change Summary

_update_class_schema was not called for function typed_dict_schema in json_schema.py. The TypedDictSchema doesn't have cls variable. But, we can get cls from metadata.

Related issue number

Fix #8698

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@13sin
Copy link
Contributor Author

13sin commented Feb 6, 2024

please review

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2024

CodSpeed Performance Report

Merging #8734 will not alter performance

Comparing 13sin:fix-pydantic-config-ignored-for-typedict (e54b2d5) with main (3fda9d6)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Feb 6, 2024
sydney-runkle
sydney-runkle approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@13sin,

This fix looks great, thanks!

@sydney-runkle sydney-runkle merged commit b1bb24e into pydantic:main Feb 6, 2024
@13sin 13sin deleted the fix-pydantic-config-ignored-for-typedict branch February 7, 2024 00:52
@13sin 13sin restored the fix-pydantic-config-ignored-for-typedict branch February 24, 2024 04:28
@13sin 13sin deleted the fix-pydantic-config-ignored-for-typedict branch February 24, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@davidhewitt davidhewitt

Labels

ready for review relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

__pydantic_config__ ignored in TypeAdapter for TypedDicts

3 participants

@13sin @sydney-runkle @davidhewitt