KEMBAR78
feat: environment variable to disable plugins by geospackle · Pull Request #8767 · pydantic/pydantic · GitHub
Skip to content

feat: environment variable to disable plugins #8767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 13, 2024
Merged

feat: environment variable to disable plugins #8767

merged 10 commits into from
Feb 13, 2024

Conversation

@geospackle
Copy link
Contributor

@geospackle geospackle commented Feb 8, 2024 •
edited by pydantic-hooky bot
Loading

Change Summary

Environment variable PYDANTIC_DISABLE_PLUGINS can be used to disable all or specified plugins.

Related issue number

#7709

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8767 will not alter performance

Comparing geospackle:am/disable-plugins (e89c7e3) with main (14ce997)

Summary

✅ 10 untouched benchmarks

@geospackle
Copy link
Contributor Author

please review

@geospackle
Copy link
Contributor Author

  1. Should we add a warning when plugin is disabled?
  2. Is it useful to add default value 0 to enable plugins?

Kludex
Kludex reviewed Feb 12, 2024
View reviewed changes
Kludex
Kludex reviewed Feb 12, 2024
View reviewed changes
pantero and others added 2 commits February 12, 2024 11:33
refactor: disables plugins
9a11cd5
@geospackle @Kludex
docs: formatting
ab22e38 
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
Kludex reviewed Feb 12, 2024
View reviewed changes
Kludex
Kludex reviewed Feb 12, 2024
View reviewed changes
geospackle and others added 3 commits February 12, 2024 08:48
@geospackle @Kludex
refactor: shorten conditional statement
497b7f0 
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@geospackle @Kludex
docs: formatting
2d37767 
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Merge branch 'main' into am/disable-plugins
d3a8f37
@sydney-runkle
Copy link
Contributor

@geospackle,

Looks good overall, but we'll have to fix the tests before merging 👍. Could you please look into those errors?

@geospackle
Copy link
Contributor Author

@geospackle,

Looks good overall, but we'll have to fix the tests before merging 👍. Could you please look into those errors?

I noticed that. Turns out globals were leaking to other tests and needed teardown on the fixture. Got the changes pushed now.

@sydney-runkle
Copy link
Contributor

@geospackle,

Great, thanks! Awesome work 🚀 .

@sydney-runkle sydney-runkle merged commit b145516 into pydantic:main Feb 13, 2024
@hramezani hramezani mentioned this pull request Feb 16, 2024
Closed
@geospackle geospackle changed the title Environment variable to disable plugins feat: environment variable to disable plugins Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@dmontagu dmontagu

Labels

ready for review relnotes-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geospackle @sydney-runkle @Kludex @dmontagu