Fix test along with date -> datetime timezone assumption fix #8823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ed6e022
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d029ab4a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dt-tz-fixes.pydantic-docs2.pages.dev |
CodSpeed Performance ReportMerging #8823 will not alter performanceComparing Summary
|
davidhewitt
approved these changes
Feb 15, 2024
|
Shoutout to the pydantic team for this one! Timezones are a huge headache for us, so I used pydantic to create an array of custom types that handle timezones in a more nuanced way. I updated the pydantic version in one of our analytics libraries today and caught this update in one of my unit tests. Ez fix! Pretty cool to see how things propagate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In concert with #8762 and pydantic/pydantic-core#1193