KEMBAR78
Fix deprecation warning with usage of `ast.Str` by Viicos · Pull Request #8837 · pydantic/pydantic · GitHub
Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Feb 16, 2024

Change Summary

Will be removed in 3.14

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2024

CodSpeed Performance Report

Merging #8837 will not alter performance

Comparing Viicos:deprecated-ast-str (1f22c55) with main (3dd3b42)

Summary

✅ 10 untouched benchmarks

@alexmojaki alexmojaki added the relnotes-fix Used for bugfixes. label Feb 16, 2024
@alexmojaki
Copy link
Contributor

@Viicos is this fine to merge?

@Viicos
Copy link
Member Author

Viicos commented Feb 16, 2024

Sure

@alexmojaki alexmojaki merged commit 12ebdfc into pydantic:main Feb 16, 2024
@Viicos Viicos deleted the deprecated-ast-str branch February 16, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants