KEMBAR78
Reorganize `pyproject.toml` sections by Viicos · Pull Request #8899 · pydantic/pydantic · GitHub
Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Feb 27, 2024

As per #8237.

the project table wasn't set at the top of file, which would make pdm move it around in the file each time a pdm command was run.

Added packaging as a dev dependency. It is used in #8237 but added here to avoid conflicts (packaging is already implicitly included in the lock file so test passes in #8237, this is just to make it explicit here)

Add `packaging` as a `testing` dev dependency
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 27, 2024

CodSpeed Performance Report

Merging #8899 will not alter performance

Comparing Viicos:reorganize-pyproject (47dfd31) with main (9811727)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle added the relnotes-packaging Used for dependency changes. label Feb 27, 2024
@sydney-runkle
Copy link
Contributor

Changes look great. Thanks!

@sydney-runkle sydney-runkle merged commit 752daaf into pydantic:main Feb 27, 2024
@Viicos Viicos deleted the reorganize-pyproject branch February 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-packaging Used for dependency changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants